minor symfony#26480 [minor] SCA with Php Inspections (EA Ultimate) (kalessil)

This PR was merged into the 2.7 branch.

Discussion
----------

[minor] SCA with Php Inspections (EA Ultimate)

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n.a

Addressed some cases with one-time used local variables and repetitive calls.

Commits
-------

f16d99e Php Inspections (EA Ultimate): address some of one-time used local variables

Author: fabpot

src/Symfony/Bridge/Twig/Translation/TwigExtractor.php

@@ -54,8 +54,7 @@ public function __construct(Environment $twig)
      */
     public function extract($resource, MessageCatalogue $catalogue)
     {
-        $files = $this->extractFiles($resource);
-        foreach ($files as $file) {
+        foreach ($this->extractFiles($resource) as $file) {
             try {
                 $this->extractTemplate(file_get_contents($file->getPathname()), $catalogue);
             } catch (Error $e) {

src/Symfony/Component/DomCrawler/Crawler.php

@@ -1039,8 +1039,6 @@ private function findNamespacePrefixes($xpath)
      */
     private function createSubCrawler($nodes)
     {
-        $crawler = new static($nodes, $this->uri, $this->baseHref);
-
-        return $crawler;
+        return new static($nodes, $this->uri, $this->baseHref);
     }
 }

src/Symfony/Component/Form/ChoiceList/LegacyChoiceListAdapter.php

@@ -133,9 +133,7 @@ private function initialize()
         $this->values = array();
         $this->structuredValues = $this->adaptedList->getValues();
 
-        $innerChoices = $this->adaptedList->getChoices();
-
-        foreach ($innerChoices as $index => $choice) {
+        foreach ($this->adaptedList->getChoices() as $index => $choice) {
             $value = $this->structuredValues[$index];
             $this->values[] = $value;
             $this->choices[$value] = $choice;

src/Symfony/Component/Form/Extension/Core/Type/FormType.php

@@ -81,6 +81,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
             }
         }
 
+        $formConfig = $form->getConfig();
         $view->vars = array_replace($view->vars, array(
             'read_only' => $readOnly,
             'errors' => $form->getErrors(),
@@ -92,9 +93,9 @@ public function buildView(FormView $view, FormInterface $form, array $options)
             'pattern' => isset($options['attr']['pattern']) ? $options['attr']['pattern'] : null, // Deprecated
             'size' => null,
             'label_attr' => $options['label_attr'],
-            'compound' => $form->getConfig()->getCompound(),
-            'method' => $form->getConfig()->getMethod(),
-            'action' => $form->getConfig()->getAction(),
+            'compound' => $formConfig->getCompound(),
+            'method' => $formConfig->getMethod(),
+            'action' => $formConfig->getAction(),
             'submitted' => $form->isSubmitted(),
         ));
     }

src/Symfony/Component/Form/Extension/Validator/EventListener/ValidationListener.php

@@ -61,9 +61,7 @@ public function validateForm(FormEvent $event)
 
         if ($form->isRoot()) {
             // Validate the form in group "Default"
-            $violations = $this->validator->validate($form);
-
-            foreach ($violations as $violation) {
+            foreach ($this->validator->validate($form) as $violation) {
                 // Allow the "invalid" constraint to be put onto
                 // non-synchronized forms
                 // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)

src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php

@@ -261,12 +261,8 @@ protected function guess($class, $property, \Closure $closure, $defaultValue = n
         $classMetadata = $this->metadataFactory->getMetadataFor($class);
 
         if ($classMetadata instanceof ClassMetadataInterface && $classMetadata->hasPropertyMetadata($property)) {
-            $memberMetadatas = $classMetadata->getPropertyMetadata($property);
-
-            foreach ($memberMetadatas as $memberMetadata) {
-                $constraints = $memberMetadata->getConstraints();
-
-                foreach ($constraints as $constraint) {
+            foreach ($classMetadata->getPropertyMetadata($property) as $memberMetadata) {
+                foreach ($memberMetadata->getConstraints() as $constraint) {
                     if ($guess = $closure($constraint)) {
                         $guesses[] = $guess;
                     }