feature symfony#25131 [SecurityBundle][Security][Translation] trigger some deprecations for legacy methods (xabbuh)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

e3396ea trigger some deprecations for legacy methods

Author: Robin Chalas

UPGRADE-4.1.md

@@ -0,0 +1,18 @@
+UPGRADE FROM 4.0 to 4.1
+=======================
+
+Security
+--------
+
+ * The `ContextListener::setLogoutOnUserChange()` method is deprecated and will be removed in 5.0.
+
+SecurityBundle
+--------------
+
+ * The `logout_on_user_change` firewall option is deprecated and will be removed in 5.0.
+
+Translation
+-----------
+
+ * The `FileDumper::setBackup()` method is deprecated and will be removed in 5.0.
+ * The `TranslationWriter::disableBackup()` method is deprecated and will be removed in 5.0.

UPGRADE-5.0.md

@@ -0,0 +1,18 @@
+UPGRADE FROM 4.x to 5.0
+=======================
+
+Security
+--------
+
+ * The `ContextListener::setLogoutOnUserChange()` method has been removed.
+
+SecurityBundle
+--------------
+
+ * The `logout_on_user_change` firewall option has been removed.
+
+Translation
+-----------
+
+ * The `FileDumper::setBackup()` method has been removed.
+ * The `TranslationWriter::disableBackup()` method has been removed.

src/Symfony/Bundle/SecurityBundle/CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.1.0
+-----
+
+ * The `logout_on_user_change` firewall option is deprecated and will be removed in 5.0.
+
 4.0.0
 -----
 

src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php

@@ -200,6 +200,7 @@ private function addFirewallsSection(ArrayNodeDefinition $rootNode, array $facto
             ->booleanNode('logout_on_user_change')
                 ->defaultTrue()
                 ->info('When true, it will trigger a logout for the user if something has changed.')
+                ->setDeprecated('The "%path%.%node%" configuration key has been deprecated in Symfony 4.1 and will be removed in 5.0.')
             ->end()
             ->arrayNode('logout')
                 ->treatTrueLike(array())
@@ -290,17 +291,6 @@ private function addFirewallsSection(ArrayNodeDefinition $rootNode, array $facto
                     return $firewall;
                 })
             ->end()
-            ->validate()
-                ->ifTrue(function ($v) {
-                    return (isset($v['stateless']) && true === $v['stateless']) || (isset($v['security']) && false === $v['security']);
-                })
-                ->then(function ($v) {
-                    // this option doesn't change behavior when true when stateless, so prevent deprecations
-                    $v['logout_on_user_change'] = true;
-
-                    return $v;
-                })
-            ->end()
         ;
     }
 

src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

@@ -181,8 +181,6 @@ private function createFirewalls($config, ContainerBuilder $container)
                 $customUserChecker = true;
             }
 
-            $contextListenerDefinition->addMethodCall('setLogoutOnUserChange', array($firewall['logout_on_user_change']));
-
             $configId = 'security.firewall.map.config.'.$name;
 
             list($matcher, $listeners, $exceptionListener) = $this->createFirewall($container, $name, $firewall, $authenticationProviders, $providerIds, $configId);
@@ -410,7 +408,7 @@ private function createAuthenticationListeners($container, $id, $firewall, &$aut
                             throw new InvalidConfigurationException(sprintf('Invalid firewall "%s": user provider "%s" not found.', $id, $firewall[$key]['provider']));
                         }
                         $userProvider = $providerIds[$normalizedName];
-                    } elseif($defaultProvider) {
+                    } elseif ($defaultProvider) {
                         $userProvider = $defaultProvider;
                     } else {
                         throw new InvalidConfigurationException(sprintf('Not configuring explicitly the provider for the "%s" listener on "%s" firewall is ambiguous as there is more than one registered provider.', $key, $id));

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/argon2i_encoder.php

@@ -13,7 +13,6 @@
         'main' => array(
             'form_login' => false,
             'http_basic' => null,
-            'logout_on_user_change' => true,
         ),
     ),
 ));

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/container1.php

@@ -72,7 +72,6 @@
             'logout' => true,
             'remember_me' => array('secret' => 'TheSecret'),
             'user_checker' => null,
-            'logout_on_user_change' => true,
         ),
         'host' => array(
             'provider' => 'default',
@@ -81,14 +80,12 @@
             'methods' => array('GET', 'POST'),
             'anonymous' => true,
             'http_basic' => true,
-            'logout_on_user_change' => true,
         ),
         'with_user_checker' => array(
             'provider' => 'default',
             'user_checker' => 'app.user_checker',
             'anonymous' => true,
             'http_basic' => true,
-            'logout_on_user_change' => true,
         ),
     ),
 

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/firewall_provider.php

@@ -15,12 +15,10 @@
         'main' => array(
             'provider' => 'default',
             'form_login' => true,
-            'logout_on_user_change' => true,
         ),
         'other' => array(
             'provider' => 'with-dash',
             'form_login' => true,
-            'logout_on_user_change' => true,
         ),
     ),
 ));

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/firewall_undefined_provider.php

@@ -12,7 +12,6 @@
         'main' => array(
             'provider' => 'undefined',
             'form_login' => true,
-            'logout_on_user_change' => true,
         ),
     ),
 ));

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/php/listener_provider.php

@@ -11,7 +11,6 @@
     'firewalls' => array(
         'main' => array(
             'form_login' => array('provider' => 'default'),
-            'logout_on_user_change' => true,
         ),
     ),
 ));