SCA: use 'yield from' where it does make sense

Author: kalessil

src/Symfony/Component/Cache/Adapter/PhpArrayAdapter.php

@@ -281,9 +281,7 @@ private function generateItems(array $keys): \Generator
         }
 
         if ($fallbackKeys) {
-            foreach ($this->pool->getItems($fallbackKeys) as $key => $item) {
-                yield $key => $item;
-            }
+            yield from $this->pool->getItems($fallbackKeys);
         }
     }
 

src/Symfony/Component/Cache/Simple/PhpArrayCache.php

@@ -242,9 +242,7 @@ private function generateItems(array $keys, $default)
         }
 
         if ($fallbackKeys) {
-            foreach ($this->pool->getMultiple($fallbackKeys, $default) as $key => $item) {
-                yield $key => $item;
-            }
+            yield from $this->pool->getMultiple($fallbackKeys, $default);
         }
     }
 }

src/Symfony/Component/Config/Loader/FileLoader.php

@@ -122,9 +122,7 @@ protected function glob(string $pattern, bool $recursive, &$resource = null, boo
         }
         $resource = new GlobResource($prefix, $pattern, $recursive, $forExclusion, $excluded);
 
-        foreach ($resource as $path => $info) {
-            yield $path => $info;
-        }
+        yield from $resource;
     }
 
     private function doImport($resource, $type = null, bool $ignoreErrors = false, $sourceResource = null)

src/Symfony/Component/Process/InputStream.php

@@ -78,9 +78,7 @@ public function getIterator()
             $current = array_shift($this->input);
 
             if ($current instanceof \Iterator) {
-                foreach ($current as $cur) {
-                    yield $cur;
-                }
+                yield from $current;
             } else {
                 yield $current;
             }

src/Symfony/Component/VarDumper/Cloner/Data.php

@@ -115,9 +115,7 @@ public function getIterator()
             throw new \LogicException(sprintf('%s object holds non-iterable type "%s".', self::class, \gettype($value)));
         }
 
-        foreach ($value as $k => $v) {
-            yield $k => $v;
-        }
+        yield from $value;
     }
 
     public function __get($key)