minor symfony#31950 [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 9025ded97a39 · 2019-06-09T18:15:11.000+02:00
This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes symfony#31950). Discussion ---------- [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been added by @yceruto in symfony#28878 but it doesn't make sense to me: the interface has no concept if deprecation (`OptionsResolver` has!) Commits ------- adc7e6a [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
diff --git a/src/Symfony/Component/OptionsResolver/Options.php b/src/Symfony/Component/OptionsResolver/Options.php
@@ -16,8 +16,6 @@
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  * @author Tobias Schultze <http://tobion.de>
- *
- * @method mixed offsetGet(string $option, bool $triggerDeprecation = true)
  */
 interface Options extends \ArrayAccess, \Countable
 {

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@`
`16`	`16`	`*`
`17`	`17`	`* @author Bernhard Schussek <bschussek@gmail.com>`
`18`	`18`	`* @author Tobias Schultze <http://tobion.de>`
`19`		`- *`
`20`		`- * @method mixed offsetGet(string $option, bool $triggerDeprecation = true)`
`21`	`19`	`*/`
`22`	`20`	`interface Options extends \ArrayAccess, \Countable`
`23`	`21`	`{`