Merge pull request #696 from ferhatelmas/simplify-again

*: simplication

Author: orirawlings

object_walker.go

@@ -36,10 +36,7 @@ func (p *objectWalker) walkAllRefs() error {
 		}
 		return p.walkObjectTree(ref.Hash())
 	})
-	if err != nil {
-		return err
-	}
-	return nil
+	return err
 }
 
 func (p *objectWalker) isSeen(hash plumbing.Hash) bool {

storage/filesystem/internal/dotgit/dotgit.go

@@ -212,11 +212,7 @@ func (d *DotGit) DeleteOldObjectPackAndIndex(hash plumbing.Hash, t time.Time) er
 	if err != nil {
 		return err
 	}
-	err = d.fs.Remove(d.objectPackPath(hash, `idx`))
-	if err != nil {
-		return err
-	}
-	return nil
+	return d.fs.Remove(d.objectPackPath(hash, `idx`))
 }
 
 // NewObject return a writer for a new object file.

worktree_test.go

@@ -1481,7 +1481,7 @@ func (s *WorktreeSuite) TestGrep(c *C) {
 					break
 				}
 			}
-			if found != true {
+			if !found {
 				c.Errorf("unexpected grep results for %q, expected result to contain: %v", tc.name, wantResult)
 			}
 		}
@@ -1496,7 +1496,7 @@ func (s *WorktreeSuite) TestGrep(c *C) {
 					break
 				}
 			}
-			if found != false {
+			if found {
 				c.Errorf("unexpected grep results for %q, expected result to NOT contain: %v", tc.name, dontWantResult)
 			}
 		}