plumbing: object: Clamp object timestamps before unix epoch to unix epoch

taruti · taruti · commit ba3ee05efbde · 2018-08-29T13:44:35.000Z
Signed-off-by: Taru Karttunen &lt;taruti@taruti.net&gt;
diff --git a/plumbing/object/object.go b/plumbing/object/object.go
@@ -152,7 +152,11 @@ func (s *Signature) decodeTimeAndTimeZone(b []byte) {
 }
 
 func (s *Signature) encodeTimeAndTimeZone(w io.Writer) error {
-	_, err := fmt.Fprintf(w, "%d %s", s.When.Unix(), s.When.Format("-0700"))
+	u := s.When.Unix()
+	if u < 0 {
+		u = 0
+	}
+	_, err := fmt.Fprintf(w, "%d %s", u, s.When.Format("-0700"))
 	return err
 }
 
diff --git a/plumbing/object/tag_test.go b/plumbing/object/tag_test.go
@@ -265,7 +265,7 @@ func (s *TagSuite) TestStringNonCommit(c *C) {
 	c.Assert(tag.String(), Equals,
 		"tag TAG TWO\n"+
 			"Tagger:  <>\n"+
-			"Date:   Mon Jan 01 00:00:00 0001 +0000\n"+
+			"Date:   Thu Jan 01 00:00:00 1970 +0000\n"+
 			"\n"+
 			"tag two\n")
 }

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,11 @@ func (s *Signature) decodeTimeAndTimeZone(b []byte) {`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`func (s *Signature) encodeTimeAndTimeZone(w io.Writer) error {`
`155`		`- _, err := fmt.Fprintf(w, "%d %s", s.When.Unix(), s.When.Format("-0700"))`
	`155`	`+ u := s.When.Unix()`
	`156`	`+ if u < 0 {`
	`157`	`+ u = 0`
	`158`	`+ }`
	`159`	`+ _, err := fmt.Fprintf(w, "%d %s", u, s.When.Format("-0700"))`
`156`	`160`	`return err`
`157`	`161`	`}`
`158`	`162`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ func (s TagSuite) TestStringNonCommit(c C) {`
`265`	`265`	`c.Assert(tag.String(), Equals,`
`266`	`266`	`"tag TAG TWO\n"+`
`267`	`267`	`"Tagger: <>\n"+`
`268`		`- "Date: Mon Jan 01 00:00:00 0001 +0000\n"+`
	`268`	`+ "Date: Thu Jan 01 00:00:00 1970 +0000\n"+`
`269`	`269`	`"\n"+`
`270`	`270`	`"tag two\n")`
`271`	`271`	`}`