git: do not expose storage options in PlainOpen

Signed-off-by: Javi Fontan <jfontan@gmail.com>

Author: jfontan

options.go

@@ -9,7 +9,6 @@ import (
 	"gopkg.in/src-d/go-git.v4/plumbing"
 	"gopkg.in/src-d/go-git.v4/plumbing/object"
 	"gopkg.in/src-d/go-git.v4/plumbing/protocol/packp/sideband"
-	"gopkg.in/src-d/go-git.v4/plumbing/storer"
 	"gopkg.in/src-d/go-git.v4/plumbing/transport"
 )
 
@@ -429,9 +428,6 @@ func (o *GrepOptions) Validate(w *Worktree) error {
 // PlainOpenOptions describes how opening a plain repository should be
 // performed.
 type PlainOpenOptions struct {
-	// Storage layer options.
-	Storage storer.Options
-
 	// DetectDotGit defines whether parent directories should be
 	// walked until a .git directory or file is found.
 	DetectDotGit bool

repository.go

@@ -251,7 +251,7 @@ func PlainOpenWithOptions(path string, o *PlainOpenOptions) (*Repository, error)
 		return nil, err
 	}
 
-	s, err := filesystem.NewStorageWithOptions(dot, o.Storage)
+	s, err := filesystem.NewStorage(dot)
 	if err != nil {
 		return nil, err
 	}

repository_test.go

@@ -550,28 +550,6 @@ func (s *RepositorySuite) TestPlainOpenNotExistsDetectDotGit(c *C) {
 	c.Assert(r, IsNil)
 }
 
-func (s *RepositorySuite) TestPlainOpenStatic(c *C) {
-	dir, err := ioutil.TempDir("", "plain-open")
-	c.Assert(err, IsNil)
-	defer os.RemoveAll(dir)
-
-	r, err := PlainInit(dir, true)
-	c.Assert(err, IsNil)
-	c.Assert(r, NotNil)
-
-	op := &PlainOpenOptions{
-		Storage: storer.Options{Static: true},
-	}
-
-	r, err = PlainOpenWithOptions(dir, op)
-	c.Assert(err, IsNil)
-	c.Assert(r, NotNil)
-
-	sto, ok := r.Storer.(*filesystem.Storage)
-	c.Assert(ok, Equals, true)
-	c.Assert(sto.Options.Static, Equals, true)
-}
-
 func (s *RepositorySuite) TestPlainClone(c *C) {
 	r, err := PlainClone(c.MkDir(), false, &CloneOptions{
 		URL: s.GetBasicLocalRepositoryURL(),