Merge branch 'feature/generic-syntax-check-short-echo-tag' of https://github.com/jrfnl/PHP_CodeSniffer

Author: gsherwood

package.xml

@@ -729,7 +729,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
         <file baseinstalldir="PHP/CodeSniffer" name="RequireStrictTypesUnitTest.php" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="SAPIUsageUnitTest.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="SAPIUsageUnitTest.php" role="test" />
-        <file baseinstalldir="PHP/CodeSniffer" name="SyntaxUnitTest.inc" role="test" />
+        <file baseinstalldir="PHP/CodeSniffer" name="SyntaxUnitTest.1.inc" role="test" />
+        <file baseinstalldir="PHP/CodeSniffer" name="SyntaxUnitTest.2.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="SyntaxUnitTest.php" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="UpperCaseConstantUnitTest.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="UpperCaseConstantUnitTest.inc.fixed" role="test" />

src/Standards/Generic/Sniffs/PHP/SyntaxSniff.php

@@ -33,7 +33,10 @@ class SyntaxSniff implements Sniff
      */
     public function register()
     {
-        return [T_OPEN_TAG];
+        return [
+            T_OPEN_TAG,
+            T_OPEN_TAG_WITH_ECHO,
+        ];
 
     }//end register()
 

src/Standards/Generic/Tests/PHP/SyntaxUnitTest.inc renamed to src/Standards/Generic/Tests/PHP/SyntaxUnitTest.1.inc

@@ -0,0 +1,3 @@
+<?= 'text' ?>
+<div>text</div>
+<?= if($x) { $y = 'text'; } ?>

src/Standards/Generic/Tests/PHP/SyntaxUnitTest.2.inc

@@ -22,11 +22,21 @@ class SyntaxUnitTest extends AbstractSniffUnitTest
      * The key of the array should represent the line number and the value
      * should represent the number of errors that should occur on that line.
      *
+     * @param string $testFile The name of the file being tested.
+     *
      * @return array<int, int>
      */
-    public function getErrorList()
+    public function getErrorList($testFile='')
     {
-        return [3 => 1];
+        switch ($testFile) {
+        case 'SyntaxUnitTest.1.inc':
+        case 'SyntaxUnitTest.2.inc':
+            return [3 => 1];
+            break;
+        default:
+            return [];
+            break;
+        }
 
     }//end getErrorList()