add rgba contrast checking by converting rgba to a solid rgb color #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to, we are doing the maths!
The rest of the code expects bgColour to be a string
Everything else expects them as %. Also, rework to reduce rounding problems.
Take this structure of backgrounds for example, 1 being the closest element: 1. rgba(10,10,10, .5); 2. rgba(10,10,50, .1); 3. rgb(10,10,250); We need to transform background 2 into a solid color before we transform background 1 into a solid colour.
Contributor
Author
|
@lwright-sq any word on this? |
Contributor
Author
|
@lwright-sq It looks like this now has some merge conflicts. Do you want me to fix it? |
Conflicts: Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3.js Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
Contributor
Author
|
@lwright-sq fixed conflicts |
Member
|
Closing in favour of #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts both background and text from rgba to a solid rgb color during contrast checking.
Heads up: I'm not a js/node expert, nor have I worked with colors like this before, so I would like if this could be reviewed carefully. :)