Now testing for focusable before reporting on validity of href attribute. Fixes issue #267.

ironikart · ironikart · commit a27818089052 · 2019-09-30T08:50:56.000+10:00
diff --git a/Standards/WCAG2AAA/Sniffs/Principle2/Guideline2_4/2_4_1.js b/Standards/WCAG2AAA/Sniffs/Principle2/Guideline2_4/2_4_1.js
@@ -110,7 +110,7 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle2_Guideline2_4_2_4_1 = {
      */
     testSameDocFragmentLinks: function(element, top)
     {
-        if (element.hasAttribute('href') === true) {
+        if (element.hasAttribute('href') === true && HTMLCS.util.isFocusable(element) === true) {
             var href = element.getAttribute('href');
             href     = HTMLCS.util.trim(href);
             if ((href.length > 1) && (href.charAt(0) === '#')) {
diff --git a/Tests/WCAG2/2_4_1_Bypass.html b/Tests/WCAG2/2_4_1_Bypass.html
@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>2.4.1 Bypass</title>
+<!-- @HTMLCS_Test@
+Name: SC 2.4.1 Bypass
+Standard: WCAG2AA
+Assert: No Error *.G1,G123,G124.NoSuchID on #hidden-anchor
+-->
+<style type="text/css">
+.d-none {
+  display: none;
+}
+</style>
+</head>
+<body>
+
+<a href="#main-content" id="hidden-anchor" class="d-none">
+  Skip to main content
+</a>
+
+</body>
+</html>
+
+

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle2_Guideline2_4_2_4_1 = {`
`110`	`110`	`*/`
`111`	`111`	`testSameDocFragmentLinks: function(element, top)`
`112`	`112`	`{`
`113`		`- if (element.hasAttribute('href') === true) {`
	`113`	`+ if (element.hasAttribute('href') === true && HTMLCS.util.isFocusable(element) === true) {`
`114`	`114`	`var href = element.getAttribute('href');`
`115`	`115`	`href = HTMLCS.util.trim(href);`
`116`	`116`	`if ((href.length > 1) && (href.charAt(0) === '#')) {`