Merge pull request #283 from esbenam/avoid-throwing-errors-in-translations

ironikart · web-flow · commit 78bd10d634e3 · 2020-06-16T09:06:59.000+10:00
Don't throw an error when missing a translation - just log
diff --git a/HTMLCS.js b/HTMLCS.js
@@ -84,13 +84,15 @@ _global.HTMLCS = new function()
         var translations = _global.translation[this.lang];
 
         if (!translations) {
-            throw new Error ('Missing translations for language ' + this.lang);
+            console.error('Missing translations for language ' + this.lang);
+            return '';
         }
 
         var translation = translations[text];
 
         if (!translation) {
-            throw new Error('Translation for "' + text + '" does not exist in current language ' + this.lang);
+            console.error('Translation for "' + text + '" does not exist in current language ' + this.lang);
+            return '';
         }
 
         return translation;

Original file line number	Diff line number	Diff line change
`@@ -84,13 +84,15 @@ _global.HTMLCS = new function()`
`84`	`84`	`var translations = _global.translation[this.lang];`
`85`	`85`
`86`	`86`	`if (!translations) {`
`87`		`- throw new Error ('Missing translations for language ' + this.lang);`
	`87`	`+ console.error('Missing translations for language ' + this.lang);`
	`88`	`+ return '';`
`88`	`89`	`}`
`89`	`90`
`90`	`91`	`var translation = translations[text];`
`91`	`92`
`92`	`93`	`if (!translation) {`
`93`		`- throw new Error('Translation for "' + text + '" does not exist in current language ' + this.lang);`
	`94`	`+ console.error('Translation for "' + text + '" does not exist in current language ' + this.lang);`
	`95`	`+ return '';`
`94`	`96`	`}`
`95`	`97`
`96`	`98`	`return translation;`