Bug fix: Find in preferences/configurations dialog:

  Double clicking any empty node now always shows the preference/configuration.

Author: GWA

sql12/core/doc/changes.txt

@@ -57,6 +57,9 @@ Table cell data popup now offers find, Xml/Json-reformatting and export function
 
 Bug fixes:
 
+Find in preferences/configurations dialog:
+  Double clicking any empty node now always shows the preference/configuration.
+
 SQL result table: Section count, position and sum were updated at the end of a selection only,
   not as the used to be during the selection, too.
 

sql12/core/src/net/sourceforge/squirrel_sql/client/mainframe/action/findprefs/FindInPreferencesCtrl.java

@@ -1,27 +1,29 @@
 package net.sourceforge.squirrel_sql.client.mainframe.action.findprefs;
 
-import net.sourceforge.squirrel_sql.client.Main;
-import net.sourceforge.squirrel_sql.client.gui.mainframe.MainFrame;
-import net.sourceforge.squirrel_sql.fw.gui.GUIUtils;
-import net.sourceforge.squirrel_sql.fw.util.StringManager;
-import net.sourceforge.squirrel_sql.fw.util.StringManagerFactory;
-import net.sourceforge.squirrel_sql.fw.util.StringUtilities;
-import org.apache.commons.lang3.StringUtils;
-
-import javax.swing.*;
+import java.awt.Rectangle;
+import java.awt.event.KeyAdapter;
+import java.awt.event.KeyEvent;
+import java.awt.event.MouseAdapter;
+import java.awt.event.MouseEvent;
+import java.util.List;
+import javax.swing.JMenuItem;
+import javax.swing.JPopupMenu;
+import javax.swing.SwingUtilities;
 import javax.swing.event.DocumentEvent;
 import javax.swing.event.DocumentListener;
 import javax.swing.event.TreeSelectionEvent;
 import javax.swing.tree.DefaultMutableTreeNode;
 import javax.swing.tree.DefaultTreeModel;
 import javax.swing.tree.TreePath;
 import javax.swing.tree.TreeSelectionModel;
-import java.awt.*;
-import java.awt.event.KeyAdapter;
-import java.awt.event.KeyEvent;
-import java.awt.event.MouseAdapter;
-import java.awt.event.MouseEvent;
-import java.util.List;
+
+import net.sourceforge.squirrel_sql.client.Main;
+import net.sourceforge.squirrel_sql.client.gui.mainframe.MainFrame;
+import net.sourceforge.squirrel_sql.fw.gui.GUIUtils;
+import net.sourceforge.squirrel_sql.fw.util.StringManager;
+import net.sourceforge.squirrel_sql.fw.util.StringManagerFactory;
+import net.sourceforge.squirrel_sql.fw.util.StringUtilities;
+import org.apache.commons.lang3.StringUtils;
 
 public class FindInPreferencesCtrl
 {
@@ -123,7 +125,11 @@ private void onTreeClicked(MouseEvent me)
 
          final GotoHandler gotoHandler = new GotoHandler();
 
-         gotoHandler.gotoPath(componentPath, true);
+         // The tree node has no kids probably because of the search criterion.
+         // Hence, the double click has no nodes to expand or collapse. and we can allow the go to.
+         boolean gotoLeafOnly = ! ((DefaultMutableTreeNode) selectionPath.getLastPathComponent()).isLeaf();
+
+         gotoHandler.gotoPath(componentPath, gotoLeafOnly);
       }
    }