Feature: #41

  Table cell data popup dialog now offers a toggle button to pin the dialog.
  When pinned any further cell data will be displayed in the pinned dialog.

Author: gerdwagner

sql12/core/doc/changes.txt

@@ -6,6 +6,10 @@ Not yet released, available in our GIT repository, snapshots and future releases
 
 Enhancements:
 
+https://github.com/squirrel-sql-client/squirrel-sql-code/issues/41
+  Table cell data popup dialog now offers a toggle button to pin the dialog.
+  When pinned any further cell data will be displayed in the pinned dialog.
+
 https://github.com/squirrel-sql-client/squirrel-sql-code/issues/44
   SQL result table: Numeric values can now be right aligned,
   see menu File --> Global Preferences tab Data Types --> section "General"

sql12/core/src/net/sourceforge/squirrel_sql/client/Application.java

@@ -65,6 +65,7 @@
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.DataTypeComponentFactoryRegistry;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.DataTypePropertiesManager;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellImportExportInfoSaver;
+import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.PinnedCellDataDialogHandler;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.columndisplaychoice.CellDetailDisplayModeManager;
 import net.sourceforge.squirrel_sql.fw.gui.ErrorDialog;
 import net.sourceforge.squirrel_sql.fw.gui.action.fileexport.MultipleSqlResultExportChannel;
@@ -238,6 +239,7 @@ public class Application implements IApplication
 	private DataTypePropertiesManager _dataTypePropertiesManager = new DataTypePropertiesManager();
 
 	private CellDetailDisplayModeManager _cellDetailDisplayModeManager = new CellDetailDisplayModeManager();
+	private PinnedCellDataDialogHandler _pinnedCellDataDialogHandler = new PinnedCellDataDialogHandler();
 
 	public Application()
 	{
@@ -1558,4 +1560,10 @@ public CellDetailDisplayModeManager getCellDetailDisplayModeManager()
    {
       return _cellDetailDisplayModeManager;
    }
+
+   @Override
+   public PinnedCellDataDialogHandler getStickyCellDataDialog()
+   {
+      return _pinnedCellDataDialogHandler;
+   }
 }

sql12/core/src/net/sourceforge/squirrel_sql/client/IApplication.java

@@ -47,6 +47,7 @@
 import net.sourceforge.squirrel_sql.client.shortcut.ShortcutManager;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.DataTypeComponentFactoryRegistry;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.DataTypePropertiesManager;
+import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.PinnedCellDataDialogHandler;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.columndisplaychoice.CellDetailDisplayModeManager;
 import net.sourceforge.squirrel_sql.fw.gui.action.fileexport.MultipleSqlResultExportChannel;
 import net.sourceforge.squirrel_sql.fw.gui.action.rowselectionwindow.RowsWindowFrameRegistry;
@@ -315,4 +316,6 @@ interface IMenuIDs extends MainFrame.IMenuIDs
 	DataTypePropertiesManager getDataTypePropertiesManager();
 
 	CellDetailDisplayModeManager getCellDetailDisplayModeManager();
+
+	PinnedCellDataDialogHandler getStickyCellDataDialog();
 }

sql12/core/src/net/sourceforge/squirrel_sql/client/resources/SquirrelResources.java

@@ -207,6 +207,8 @@ public interface IImageNames
 
 		String RUN_ALL = "run_all";
 
+		String PINNED = "pinned";
+
 	}
 
 	public SquirrelResources(String rsrcBundleBaseName)

sql12/core/src/net/sourceforge/squirrel_sql/client/resources/images/eclipse/pinned.gif

@@ -196,6 +196,8 @@ show_detail.image=show_detail.png
 
 run_all.image=eclipse/active/run_all.png
 
+pinned.image=pinned.png
+
 ########
 # Configuration information for ObjectTreeInternalFrame.
 ########
@@ -495,7 +497,7 @@ action.net.sourceforge.squirrel_sql.client.session.action.CloseCurrentSQLResultT
 action.net.sourceforge.squirrel_sql.client.session.action.CloseCurrentSQLResultTabAction.name=Close current SQL Result Tab
 action.net.sourceforge.squirrel_sql.client.session.action.CloseCurrentSQLResultTabAction.tooltip=Close current SQL Result Tab
 
-action.net.sourceforge.squirrel_sql.client.session.action.ToggleCurrentSQLResultTabStickyAction.image=eclipse/pinned.gif
+action.net.sourceforge.squirrel_sql.client.session.action.ToggleCurrentSQLResultTabStickyAction.image=pinned.png
 action.net.sourceforge.squirrel_sql.client.session.action.ToggleCurrentSQLResultTabStickyAction.name=Toggle current SQL Result Tab sticky
 action.net.sourceforge.squirrel_sql.client.session.action.ToggleCurrentSQLResultTabStickyAction.tooltip=Toggle current SQL Result Tab sticky
 

sql12/core/src/net/sourceforge/squirrel_sql/client/resources/images/pinned.png

@@ -4,7 +4,7 @@
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.CellComponentFactory;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.CellRenderer;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.RestorableJTextField;
-import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataPopup;
+import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataDialogHandler;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.coloring.ColoringService;
 import net.sourceforge.squirrel_sql.fw.gui.RectangleSelectionHandler;
 import net.sourceforge.squirrel_sql.fw.gui.table.ButtonTableHeader;
@@ -15,11 +15,15 @@
 import net.sourceforge.squirrel_sql.fw.util.log.ILogger;
 import net.sourceforge.squirrel_sql.fw.util.log.LoggerController;
 
-import javax.swing.*;
+import javax.swing.DefaultCellEditor;
+import javax.swing.JOptionPane;
+import javax.swing.JTable;
 import javax.swing.table.DefaultTableColumnModel;
 import javax.swing.table.TableCellEditor;
 import javax.swing.table.TableColumnModel;
-import java.awt.*;
+import java.awt.Graphics;
+import java.awt.Point;
+import java.awt.Rectangle;
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
@@ -392,7 +396,7 @@ else if (evt.getClickCount() == 2 && false == tableClickPosition.isClickedOnTabl
          if (RowNumberTableColumn.ROW_NUMBER_MODEL_INDEX != modelIndex)
          {
             ColumnDisplayDefinition colDefs[] = _dataSetViewerTablePanel.getColumnDefinitions();
-            CellDataPopup.showDialog(this, colDefs[modelIndex], evt, _dataSetViewerTablePanel.isTableEditable());
+            CellDataDialogHandler.showDialog(this, colDefs[modelIndex], evt, _dataSetViewerTablePanel.isTableEditable());
          }
       }
    }

sql12/core/src/net/sourceforge/squirrel_sql/client/resources/squirrel.properties

@@ -21,7 +21,7 @@
  */
 
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.CellComponentFactory;
-import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataPopup;
+import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataDialogHandler;
 import net.sourceforge.squirrel_sql.fw.sql.JDBCTypeMapper;
 import net.sourceforge.squirrel_sql.fw.util.StringManager;
 import net.sourceforge.squirrel_sql.fw.util.StringManagerFactory;
@@ -264,7 +264,7 @@ else if (evt.getClickCount() == 2)
 
 						Point pt = evt.getPoint();
 						int col = RowDataJTable.this.columnAtPoint(pt);
-						CellDataPopup.showDialog(RowDataJTable.this, _colDefs[col], evt, true);
+						CellDataDialogHandler.showDialog(RowDataJTable.this, _colDefs[col], evt, true);
 					}
 				}
 				public void mouseReleased(MouseEvent evt)

sql12/core/src/net/sourceforge/squirrel_sql/fw/datasetviewer/DataSetViewerTable.java

@@ -22,7 +22,7 @@
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.whereClause.EmptyWhereClausePart;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.whereClause.IWhereClausePart;
 import net.sourceforge.squirrel_sql.fw.datasetviewer.cellcomponent.whereClause.IsNullWhereClausePart;
-import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataPopup;
+import net.sourceforge.squirrel_sql.fw.datasetviewer.celldatapopup.CellDataDialogHandler;
 import net.sourceforge.squirrel_sql.fw.dialects.DialectType;
 import net.sourceforge.squirrel_sql.fw.dialects.DialectUtils2;
 import net.sourceforge.squirrel_sql.fw.sql.ISQLDatabaseMetaData;
@@ -130,7 +130,7 @@ public void mousePressed(MouseEvent evt)
 				{
 					MouseEvent tableEvt = SwingUtilities.convertMouseEvent(
 							_textField, evt, table);
-					CellDataPopup.showDialog(table, _colDef, tableEvt, true);
+					CellDataDialogHandler.showDialog(table, _colDef, tableEvt, true);
 				}
 			}
 		}); // end of mouse listener