Merge pull request #467 from gbrunton/master

Fixes empty identifier issue

Author: ahmad-moussawi

QueryBuilder.Tests/GeneralTests.cs

@@ -89,6 +89,16 @@ public void Return_Different_MethodInfo_WhenSame_Method_With_Different_GenericTy
             Assert.NotSame(call1, call2);
         }
 
+        [Fact]
+        public void Custom_compiler_with_empty_identifier_overrides_should_remove_identifiers()
+        {
+            var compiler = new TestEmptyIdentifiersCompiler();
+
+            var wrappedValue = compiler.WrapValue("Table");
+
+            Assert.Equal("Table", wrappedValue);
+        }
+
         [Fact]
         public void Should_Equal_AfterMultipleCompile()
         {

QueryBuilder.Tests/Infrastructure/TestCompiler.cs

@@ -48,4 +48,11 @@ public virtual MethodInfo Call_FindCompilerMethodInfo(Type clauseType, string me
             return FindCompilerMethodInfo(clauseType, methodName);
         }
     }
+
+    class TestEmptyIdentifiersCompiler : TestCompiler
+    {
+        protected override string OpeningIdentifier { get; set; } = "";
+        protected override string ClosingIdentifier { get; set; } = "";
+    }
 }
+

QueryBuilder/Compilers/Compiler.cs

@@ -886,6 +886,8 @@ public virtual string WrapValue(string value)
             var opening = this.OpeningIdentifier;
             var closing = this.ClosingIdentifier;
 
+            if (string.IsNullOrWhiteSpace(opening) && string.IsNullOrWhiteSpace(closing)) return value;
+
             return opening + value.Replace(closing, closing + closing) + closing;
         }