Skip to content

Conversation

@andinux
Copy link
Collaborator

@andinux andinux commented Sep 18, 2025

Improve test speed by avoiding debug log level

Description of change

The should commands accept bindings test from database.test.ts was incorrectly using the SET KEY log_level TO debug command.

In an earlier commit (chore(test): fix a typo in the database test), I mistakenly treated the absence of log_level as a typo. In reality, the test was intentionally written not to modify the log level.

This change restores the intended behavior and makes it explicit that the test must avoid changing the log level, since doing so can cause subsequent tests to run much more slowly.

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Copy link
Member

@danielebriggi danielebriggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your fake key/value is undoubtedly better!!

@andinux andinux merged commit e56ed2d into main Sep 18, 2025
45 of 46 checks passed
@andinux andinux deleted the fix/test-speed-avoid-debug-level branch September 18, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants