Skip to content

Commit f889b05

Browse files
committed
fix auto remove db, rm clean test script
1 parent 58e80e3 commit f889b05

File tree

5 files changed

+35
-55
lines changed

5 files changed

+35
-55
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sqlitecloud/drivers",
3-
"version": "1.0.403",
3+
"version": "1.0.406",
44
"description": "SQLiteCloud drivers for Typescript/Javascript in edge, web and node clients",
55
"main": "./lib/index.js",
66
"types": "./lib/index.d.ts",

test/clean.test.ts

Lines changed: 0 additions & 40 deletions
This file was deleted.

test/compare.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* compare.test.ts - test driver api against sqlite3 equivalents
33
*/
44

5-
import { CHINOOK_DATABASE_FILE, CHINOOK_DATABASE_URL, CHINOOK_FIRST_TRACK, LONG_TIMEOUT, TESTING_SQL } from './shared'
5+
import { CHINOOK_DATABASE_FILE, CHINOOK_FIRST_TRACK, LONG_TIMEOUT, removeDatabase, TESTING_SQL } from './shared'
66
import { getChinookDatabase, getTestingDatabase } from './shared'
77

88
// https://github.com/TryGhost/node-sqlite3/wiki/API
@@ -149,13 +149,15 @@ describe('Database.run', () => {
149149
expect(this.totalChanges).toBe(21)
150150
// @ts-expect-error
151151
expect(this.finalized).toBe(1)
152-
153-
testingCloud.close()
154-
done()
155152
}
156153
const testingCloud = getTestingDatabase(error => {
157154
expect(error).toBeNull()
158155
testingCloud.run(INSERT_SQL, onInsert)
156+
157+
removeDatabase(testingCloud, error => {
158+
expect(error).toBeNull()
159+
done()
160+
})
159161
})
160162
})
161163

test/statement.test.ts

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
*/
44

55
import { SQLiteCloudRowset } from '../src'
6-
import { RowCountCallback, SQLiteCloudError } from '../src/drivers/types'
7-
import { getChinookDatabase, getTestingDatabase } from './shared'
6+
import { RowCountCallback } from '../src/drivers/types'
7+
import { getChinookDatabase, getTestingDatabase, removeDatabase } from './shared'
88

99
describe('Database.prepare', () => {
1010
it('without initial bindings', done => {
@@ -261,7 +261,10 @@ it('Statement.run - insert', done => {
261261
expect(results.lastID).toBeGreaterThan(1)
262262
expect(results.changes).toBe(1)
263263

264-
done()
264+
removeDatabase(database, error => {
265+
expect(error).toBeNull()
266+
done()
267+
})
265268
})
266269
})
267270
})
@@ -279,7 +282,10 @@ it("Statement.run - insert with empty space after semicolon shouldn't return nul
279282
expect(results.lastID).toBeGreaterThan(1)
280283
expect(results.changes).toBe(1)
281284

282-
done()
285+
removeDatabase(database, error => {
286+
expect(error).toBeNull()
287+
done()
288+
})
283289
})
284290
})
285291
})
@@ -294,7 +300,10 @@ it('Statement.run - update', done => {
294300
statement.run('John Wayne', 1, (error, results) => {
295301
expect(results.changes).toBe(1)
296302

297-
done()
303+
removeDatabase(database, error => {
304+
expect(error).toBeNull()
305+
done()
306+
})
298307
})
299308
})
300309
})
@@ -310,7 +319,10 @@ it("Statement.run - update with empty space after semicolon shouldn't return nul
310319
expect(results).not.toBeNull()
311320
expect(results.changes).toBe(1)
312321

313-
done()
322+
removeDatabase(database, error => {
323+
expect(error).toBeNull()
324+
done()
325+
})
314326
})
315327
})
316328
})
@@ -325,7 +337,10 @@ it('Statement.run - delete', done => {
325337
statement.run(1, (error, results) => {
326338
expect(results.changes).toBe(1)
327339

328-
done()
340+
removeDatabase(database, error => {
341+
expect(error).toBeNull()
342+
done()
343+
})
329344
})
330345
})
331346
})
@@ -341,7 +356,10 @@ it("Statement.run - delete with empty space after semicolon shouldn't return nul
341356
expect(results).not.toBeNull()
342357
expect(results.changes).toBe(1)
343358

344-
done()
359+
removeDatabase(database, error => {
360+
expect(error).toBeNull()
361+
done()
362+
})
345363
})
346364
})
347365
})

0 commit comments

Comments
 (0)