fix(connection): suggestions

Author: Daniele Briggi

package-lock.json

@@ -250,7 +250,7 @@ export class SQLiteCloudTlsConnection extends SQLiteCloudConnection {
   }
 
   /** Disconnect immediately, release connection, no events. */
-  public close(): this {
+  close(): this {
     if (this.socket) {
       this.socket.removeAllListeners()
       this.socket.destroy()

src/drivers/connection-tls.ts

@@ -39,7 +39,7 @@ export class SQLiteCloudWebsocketConnection extends SQLiteCloudConnection {
 
         this.socket.on('disconnect', (reason) => {
           this.close()
-          callback?.call(this, new SQLiteCloudError('Disconnected', { errorCode: 'ERR_CONNECTION_DISCONNECTED', cause: reason }))
+          callback?.call(this, new SQLiteCloudError('Disconnected', { errorCode: 'ERR_CONNECTION_ENDED', cause: reason }))
         })
 
         this.socket.on('error', (error: Error) => {

src/drivers/connection-ws.ts

@@ -60,8 +60,8 @@ it(
     const connection = new SQLiteCloudTlsConnection(configObj, error => {
       expect(error).toBeNull()
       expect(connection.connected).toBe(true)
-      done()
       connection.close()
+      done()
     })
     expect(connection).toBeDefined()
   },

test/connection-tls.test.ts

@@ -40,8 +40,8 @@ describe('connection-ws', () => {
       let connection: SQLiteCloudWebsocketConnection | null = null
       connection = new SQLiteCloudWebsocketConnection(configObj, error => {
         expect(error).toBeNull()
-        done()
         connection?.close()
+        done()
       })
     })