Merge pull request #229 from sqlitecloud/fix-config-casts

fix(config): config properties cast

Author: danielebriggi

src/drivers/utilities.ts

@@ -219,11 +219,26 @@ export function parseconnectionstring(connectionstring: string): SQLiteCloudConf
     })
 
     const config: SQLiteCloudConfig = {
+      ...options,
       username: decodeURIComponent(url.username),
       password: decodeURIComponent(url.password),
+      password_hashed: options.password_hashed ? parseBoolean(options.password_hashed) : undefined,
       host: url.hostname,
+      // type cast values
       port: url.port ? parseInt(url.port) : undefined,
-      ...options
+      insecure: options.insecure ? parseBoolean(options.insecure) : undefined,
+      timeout: options.timeout ? parseInt(options.timeout) : undefined,
+      zerotext: options.zerotext ? parseBoolean(options.zerotext) : undefined,
+      create: options.create ? parseBoolean(options.create) : undefined,
+      memory: options.memory ? parseBoolean(options.memory) : undefined,
+      compression: options.compression ? parseBoolean(options.compression) : undefined,
+      non_linearizable: options.non_linearizable ? parseBoolean(options.non_linearizable) : undefined,
+      noblob: options.noblob ? parseBoolean(options.noblob) : undefined,
+      maxdata: options.maxdata ? parseInt(options.maxdata) : undefined,
+      maxrows: options.maxrows ? parseInt(options.maxrows) : undefined,
+      maxrowset: options.maxrowset ? parseInt(options.maxrowset) : undefined,
+      usewebsocket: options.usewebsocket ? parseBoolean(options.usewebsocket) : undefined,
+      verbose: options.verbose ? parseBoolean(options.verbose) : undefined
     }
 
     // either you use an apikey or username and password

test/utilities.test.ts

@@ -57,7 +57,7 @@ describe('parseconnectionstring', () => {
     expect(config4).toEqual({
       host: 'host',
       apikey: 'yyy',
-      maxrows: '42' // only parsing here, validation is later in validateConfiguration
+      maxrows: 42 // only parsing here, validation is later in validateConfiguration
     })
   })
 
@@ -138,6 +138,30 @@ describe('parseconnectionstring', () => {
       database: 'database'
     })
   })
+
+  it('should parse connection with insecure as bool or number', () => {
+    let connectionstring = `sqlitecloud://host:1234/database?insecure=true`
+    let config = parseconnectionstring(connectionstring)
+
+    expect(config.insecure).toBe(true)
+
+    connectionstring = `sqlitecloud://host:1234/database?insecure=1`
+    config = parseconnectionstring(connectionstring)
+
+    expect(config.insecure).toBe(true)
+
+    connectionstring = `sqlitecloud://host:1234/database?insecure=0`
+    config = parseconnectionstring(connectionstring)
+
+    expect(config.insecure).toBe(false)
+  })
+
+  it('should parse connection with timeout as number', () => {
+    let connectionstring = `sqlitecloud://host:1234/database?timeout=123`
+    let config = parseconnectionstring(connectionstring)
+
+    expect(config.timeout).toBe(123)
+  })
 })
 
 describe('getTestingDatabaseName', () => {