fix(connection): suggestions

Author: Daniele Briggi

examples/with-javascript-expo/db/dbConnection.js

@@ -6,7 +6,7 @@ import { Database } from "@sqlitecloud/drivers";
  */
 let database = null;
 
-export function getDbConnection() {
+export default function getDbConnection() {
     if (!database || !database.isConnected()) {
         database = new Database(DATABASE_URL);
     }

examples/with-javascript-vite/src/App.jsx

@@ -5,7 +5,7 @@ let db = null
 
 function getDatabase() {
   if (!db || !db.isConnected()) {
-    db = new Database("chinook.sqlite");
+    db = new Database(import.meta.env.VITE_DATABASE_URL);
   }
 
   return db;

package-lock.json

@@ -250,7 +250,7 @@ export class SQLiteCloudTlsConnection extends SQLiteCloudConnection {
   }
 
   /** Disconnect immediately, release connection, no events. */
-  public close(): this {
+  close(): this {
     if (this.socket) {
       this.socket.removeAllListeners()
       this.socket.destroy()

src/drivers/connection-tls.ts

@@ -39,7 +39,7 @@ export class SQLiteCloudWebsocketConnection extends SQLiteCloudConnection {
 
         this.socket.on('disconnect', (reason) => {
           this.close()
-          callback?.call(this, new SQLiteCloudError('Disconnected', { errorCode: 'ERR_CONNECTION_DISCONNECTED', cause: reason }))
+          callback?.call(this, new SQLiteCloudError('Disconnected', { errorCode: 'ERR_CONNECTION_ENDED', cause: reason }))
         })
 
         this.socket.on('error', (error: Error) => {

src/drivers/connection-ws.ts

@@ -60,10 +60,9 @@ it(
     const connection = new SQLiteCloudTlsConnection(configObj, error => {
       expect(error).toBeNull()
       expect(connection.connected).toBe(true)
-      done()
       connection.close()
+      done()
     })
-    expect(connection).toBeDefined()
   },
   LONG_TIMEOUT
 )
@@ -82,7 +81,6 @@ it(
           done()
         })
       })
-      expect(connection).toBeDefined()
     },
     LONG_TIMEOUT
   )
@@ -103,7 +101,6 @@ it(
             done()
           })
         })
-        expect(connection).toBeDefined()
       } catch (error) {
         console.error(`An error occurred while connecting using api key: ${error}`)
         debugger
@@ -142,7 +139,6 @@ it(
         }
       })
     })
-    expect(connection).toBeDefined()
   })
 
   it('should connect with insecure connection string', done => {

test/connection-tls.test.ts

@@ -40,8 +40,8 @@ describe('connection-ws', () => {
       let connection: SQLiteCloudWebsocketConnection | null = null
       connection = new SQLiteCloudWebsocketConnection(configObj, error => {
         expect(error).toBeNull()
-        done()
         connection?.close()
+        done()
       })
     })