feat(websocket): support to bindings

Author: Daniele Briggi

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@sqlitecloud/drivers",
-  "version": "1.0.333",
+  "version": "1.0.338",
   "description": "SQLiteCloud drivers for Typescript/Javascript in edge, web and node clients",
   "main": "./lib/index.js",
   "types": "./lib/index.d.ts",

package.json

@@ -2,7 +2,7 @@
  * transport-ws.ts - handles low level communication with sqlitecloud server via socket.io websocket
  */
 
-import { SQLiteCloudConfig, SQLiteCloudError, ErrorCallback, ResultsCallback, SQLiteCloudCommand } from './types'
+import { SQLiteCloudConfig, SQLiteCloudError, ErrorCallback, ResultsCallback, SQLiteCloudCommand, SQLiteCloudDataTypes } from './types'
 import { SQLiteCloudRowset } from './rowset'
 import { SQLiteCloudConnection } from './connection'
 import { io, Socket } from 'socket.io-client'
@@ -46,9 +46,13 @@ export class SQLiteCloudWebsocketConnection extends SQLiteCloudConnection {
     if (!this.socket) {
       callback?.call(this, new SQLiteCloudError('Connection not established', { errorCode: 'ERR_CONNECTION_NOT_ESTABLISHED' }))
       return this
+    } 
+
+    if (typeof commands === 'string') {
+      commands = { query: commands }
     }
 
-    this.socket.emit('v1/sql', { sql: commands, row: 'array' }, (response: any) => {
+    this.socket.emit('v2/weblite/sql', { sql: commands.query, bind: commands.parameters, row: 'array' }, (response: any) => {
       if (response?.error) {
         const error = new SQLiteCloudError(response.error.detail, { ...response.error })
         callback?.call(this, error)

src/drivers/connection-ws.ts

@@ -2,7 +2,7 @@
  * connection-tls.test.ts - test low level communication protocol with tls sockets and raw commands
  */
 
-import { SQLiteCloudError, SQLiteCloudRowset } from '../src/index'
+import { SQLiteCloudConnection, SQLiteCloudError, SQLiteCloudRowset } from '../src/index'
 import { SQLiteCloudTlsConnection } from '../src/drivers/connection-tls'
 import { anonimizeCommand } from '../src/drivers/utilities'
 import {
@@ -1027,3 +1027,29 @@ describe('anonimizeCommand', () => {
     expect(anonimized).toBe('+62 AUTH USER ****** SOMETHING notreallyapassword; USE DATABASE chinook.sqlite; ')
   })
 })
+
+// TODO: enable this test when this isssue is fixed: https://github.com/sqlitecloud/core/issues/165
+// it('should send unicode database name as array', done => {
+//   new Promise((resolve, reject) => {
+//     const connection = new SQLiteCloudTlsConnection({ connectionstring: CHINOOK_DATABASE_URL }, error => {
+//       if (error) {
+//         expect(error).toBeNull()
+//         reject(error)
+//         done(error)
+//       }
+//       resolve(connection)
+//     })
+//   }).then((value) => {
+//     const connection = value as SQLiteCloudTlsConnection;
+//     connection.transportCommands({ query: 'USE DATABASE ?;', parameters: ['🚀.sqlite'] }, (error, result) => {
+//       if (error) {
+//         expect(error).toBeNull()
+//       } else {
+//         expect(result).toBeDefined()
+//       }
+
+//       connection.close()
+//       done(error)
+//     })
+//   })
+// })

test/connection-tls.test.ts

@@ -14,7 +14,7 @@ import {
   WARN_SPEED_MS,
   EXPECT_SPEED_MS
 } from './shared'
-import { error } from 'console'
+import { SQLiteCloudCommand } from '../src/drivers/types'
 
 describe('connection-ws', () => {
   let chinook: SQLiteCloudConnection
@@ -377,6 +377,24 @@ describe('connection-ws', () => {
           done()
         })
       })
+
+      it('should select without bindings', done => {
+        const command = { query: 'SELECT * FROM albums' } as SQLiteCloudCommand
+        chinook.sendCommands(command, (error, results) => {
+          expect(error).toBeNull()
+          expect(results.numberOfColumns).toBeGreaterThan(0)
+          done()
+        })
+      })
+
+      it('should select with bindings', done => {
+        const command: SQLiteCloudCommand = { query: 'SELECT * FROM albums WHERE albumId = ?', parameters: [1] }
+        chinook.sendCommands(command, (error, results) => {
+          expect(error).toBeNull()
+          expect(results.numberOfColumns).toBe(1)
+          done()
+        })
+      })
     })
 
     describe('connection stress testing', () => {

test/connection-ws.test.ts

@@ -3,9 +3,10 @@
  */
 
 import { SQLiteCloudRowset, SQLiteCloudRow, SQLiteCloudError, sanitizeSQLiteIdentifier } from '../src/index'
-import { getTestingDatabase, getTestingDatabaseAsync, getChinookDatabase, removeDatabase, removeDatabaseAsync, LONG_TIMEOUT } from './shared'
+import { getTestingDatabase, getTestingDatabaseAsync, getChinookDatabase, removeDatabase, removeDatabaseAsync, LONG_TIMEOUT, getChinookWebsocketConnection } from './shared'
 import { RowCountCallback } from '../src/drivers/types'
 import { expect, describe, it } from '@jest/globals'
+import { Database } from 'sqlite3'
 
 //
 // utility methods to setup and destroy temporary test databases