Move shared test utilities to shared.ts

Author: gionatamettifogo

.gitignore

@@ -122,3 +122,5 @@ lib/
 .DS_Store
 .env
 test/assets/testing.db
+
+tools/

jest.config.js

@@ -2,6 +2,7 @@ module.exports = {
   preset: 'ts-jest',
   testEnvironment: 'node',
   testMatch: ['**/test/**/*.test.ts'],
+  testTimeout: 30 * 1000,
   maxWorkers: 8,
   collectCoverageFrom: ['<rootDir>/src/**/*.ts', '!<rootDir>/src/index.ts', '!<rootDir>/src/types/**/*.ts'],
   transform: {

package-lock.json

@@ -16,30 +16,23 @@ import { SQLiteCloudConfig, SQLiteCloudError, RowCountCallback, SQLiteCloudArray
 import { prepareSql, popCallback } from './utilities'
 import { Statement } from './statement'
 import { ErrorCallback, ResultsCallback, RowCallback, RowsCallback } from './types'
+import EventEmitter from 'eventemitter3'
 
 /**
  * Creating a Database object automatically opens a connection to the SQLite database.
  * When the connection is established the Database object emits an open event and calls
  * the optional provided callback. If the connection cannot be established an error event
  * will be emitted and the optional callback is called with the error information.
  */
-export class Database {
+export class Database extends EventEmitter {
   /** Create and initialize a database from a full configuration object, or connection string */
   constructor(config: SQLiteCloudConfig | string, callback?: ErrorCallback) {
+    super()
     this.config = typeof config === 'string' ? { connectionString: config } : config
+    this.connections = []
 
     // opens first connection to the database automatically
-    const connection = new SQLiteCloudConnection(this.config)
-    this.connections = [connection]
-
-    // get a connection for the only purpose of opening the database
-    this.getConnection(error => {
-      if (error) {
-        this.handleError(null, error, callback)
-      } else {
-        callback?.call(this, null)
-      }
-    })
+    this.getConnection(callback as ResultsCallback)
   }
 
   /** Configuration used to open database connections */
@@ -59,11 +52,11 @@ export class Database {
       callback?.call(this, null, this.connections[0])
     } else {
       const connection = new SQLiteCloudConnection(this.config)
+      this.connections.push(connection)
       connection.connect(error => {
         if (error) {
           this.handleError(connection, error, callback)
         } else {
-          this.connections.push(connection)
           callback?.call(this, null)
           this.emitEvent('open')
         }
@@ -82,19 +75,10 @@ export class Database {
     if (callback) {
       callback.call(this, error)
     } else {
-      // TODO sqlitecloud-js / implement database error handling #12
       this.emitEvent('error', error)
     }
   }
 
-  /** Emits given event with optional arguments */
-  private emitEvent(event: string, ...args: any[]): void {
-    // TODO sqlitecloud-js / database emit event #16
-    if (this.config.verbose) {
-      console.log(`Database.emitEvent - '${event}'`, ...args)
-    }
-  }
-
   /**
    * Some queries like inserts or updates processed via run or exec may generate
    * an empty result (eg. no data was selected), but still have some metadata.
@@ -123,6 +107,16 @@ export class Database {
     return undefined
   }
 
+  /** Emits given event with optional arguments on the next tick so callbacks can complete first */
+  private emitEvent(event: string, ...args: any[]): void {
+    process.nextTick(() => {
+      if (this.config.verbose) {
+        console.log(`Database.emitEvent - emitted '${event}'`, ...args)
+      }
+      this.emit(event, ...args)
+    })
+  }
+
   //
   // public methods
   //