webui: Ensure deleting visualisations shows the success message too

Only when it's successful of course. :)

Author: justinclift

cypress/e2e/1-webui/live_visualisation.cy.js

@@ -237,6 +237,7 @@ describe('live visualisation', () => {
     cy.get('[data-cy="formatsqlbtn"]').click()
 
     // Verify the changed text
+    cy.wait(waitTime)
     cy.get('[data-cy="usersqltext"]').should('contain',
       'SELECT\n' +
         '  table1.Name,\n' +

webui/templates/visualise.html

@@ -436,8 +436,10 @@ <h4 style="color: {{ statusMessageColour }};" data-cy="statusmsg">&nbsp;{{ statu
             // Retrieve the SQL and chart settings for the newly chosen visualisation from the server
             $http.get("/x/visget/[[ .DB.Info.Owner ]]/[[ .DB.Info.Database ]]?visname="+newVis).then(
                 function success(response) {
-                    // Clear any existing status message
-                    $scope.statusMessage = "";
+                    if (execNewVis) {
+                        // Clear any existing status message
+                        $scope.statusMessage = "";
+                    }
 
                     // Apply the retrieved information
                     document.getElementById("savename").value = newVis;
@@ -554,10 +556,12 @@ <h4 style="color: {{ statusMessageColour }};" data-cy="statusmsg">&nbsp;{{ statu
                         $scope.db.Records = {};
                     }
                 }, function failure(response) {
-                    // Retrieving visualisation text failed, so display the returned error message
-                    $scope.statusMessageColour = "red";
-                    $scope.statusMessage = nowString() + "Retrieving visualisation failed: " + response.data;
-                    $scope.showVis = false;
+                    if (execNewVis) {
+                        // Retrieving visualisation text failed, so display the returned error message
+                        $scope.statusMessageColour = "red";
+                        $scope.statusMessage = nowString() + "Retrieving visualisation failed: " + response.data;
+                        $scope.showVis = false;
+                    }
                 }
             )
         }