Support DELETE with JOIN on subquery (#4023)

Author: gwillem

internal/endtoend/testdata/delete_join/mysql/db/query.sql.go

@@ -26,4 +26,9 @@ FROM
         RIGHT JOIN primary_table as pt ON jt.primary_table_id = pt.id
 WHERE
         jt.id = ?
-        AND pt.user_id = ?;
+        AND pt.user_id = ?;
+
+-- name: DeleteJoinWithSubquery :exec
+DELETE pt
+FROM primary_table pt
+JOIN (SELECT 1 as id) jt ON pt.id = jt.id;

internal/endtoend/testdata/delete_join/mysql/query.sql

@@ -52,6 +52,9 @@ func convertToRangeVarList(list *ast.List, result *ast.List) {
 		if !ok {
 			if list, check := rel.Larg.(*ast.List); check {
 				convertToRangeVarList(list, result)
+			} else if subselect, check := rel.Larg.(*ast.RangeSubselect); check {
+				// Handle subqueries in JOIN clauses
+				result.Items = append(result.Items, subselect)
 			} else {
 				panic("expected range var")
 			}
@@ -64,6 +67,9 @@ func convertToRangeVarList(list *ast.List, result *ast.List) {
 		if !ok {
 			if list, check := rel.Rarg.(*ast.List); check {
 				convertToRangeVarList(list, result)
+			} else if subselect, check := rel.Rarg.(*ast.RangeSubselect); check {
+				// Handle subqueries in JOIN clauses
+				result.Items = append(result.Items, subselect)
 			} else {
 				panic("expected range var")
 			}
@@ -75,6 +81,9 @@ func convertToRangeVarList(list *ast.List, result *ast.List) {
 	case *ast.RangeVar:
 		result.Items = append(result.Items, rel)
 
+	case *ast.RangeSubselect:
+		result.Items = append(result.Items, rel)
+
 	default:
 		panic("expected range var")
 	}