project review

Author: bnasslahsen

pom.xml

@@ -1,4 +1,6 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>org.springdoc</groupId>
 	<artifactId>springdoc-openapi</artifactId>
@@ -169,8 +171,8 @@
 			<build>
 				<plugins>
 					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
 						<artifactId>maven-source-plugin</artifactId>
-						<version>${maven-source-plugin.version}</version>
 						<executions>
 							<execution>
 								<id>attach-sources</id>
@@ -181,8 +183,8 @@
 						</executions>
 					</plugin>
 					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
 						<artifactId>maven-javadoc-plugin</artifactId>
-						<version>${maven-javadoc-plugin.version}</version>
 						<executions>
 							<execution>
 								<id>attach-javadocs</id>
@@ -193,6 +195,7 @@
 						</executions>
 					</plugin>
 					<plugin>
+						<groupId>org.apache.maven.plugins</groupId>
 						<artifactId>maven-gpg-plugin</artifactId>
 						<version>${maven-gpg-plugin.version}</version>
 						<executions>

springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestBuilder.java

@@ -182,7 +182,7 @@ else if (!RequestMethod.GET.equals(requestMethod)) {
 		}
 
 		LinkedHashMap<String, Parameter> map = getParameterLinkedHashMap(components, methodAttributes, operationParameters, parametersDocMap);
-		setParams(operation, new ArrayList(map.values()), requestBodyInfo);
+		setParams(operation, new ArrayList<Parameter>(map.values()), requestBodyInfo);
 		// allow for customisation
 		return customiseOperation(operation, handlerMethod);
 	}

springdoc-openapi-common/src/main/java/org/springdoc/core/OpenAPIBuilder.java

@@ -84,7 +84,6 @@ public class OpenAPIBuilder {
 	private String serverBaseUrl;
 	private final SpringDocConfigProperties springDocConfigProperties;
 
-	@SuppressWarnings("WeakerAccess")
 	OpenAPIBuilder(Optional<OpenAPI> openAPI, ApplicationContext context, SecurityParser securityParser,
 			SpringDocConfigProperties springDocConfigProperties,
 			Optional<List<OpenApiBuilderCustomiser>> openApiBuilderCustomisers) {

springdoc-openapi-common/src/main/java/org/springdoc/core/OperationBuilder.java

@@ -46,7 +46,6 @@
 
 import org.springframework.core.annotation.AnnotationUtils;
 import org.springframework.util.CollectionUtils;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import static org.springdoc.core.Constants.DEFAULT_DESCRIPTION;
 import static org.springdoc.core.Constants.DELETE_METHOD;
@@ -168,39 +167,6 @@ public Optional<Map<String, Callback>> buildCallbacks(
 			return Optional.of(callbacks);
 	}
 
-	private void fillPathItem(RequestMethod requestMethod, Operation operation, PathItem pathItemObject) {
-		switch (requestMethod) {
-			case POST:
-				pathItemObject.post(operation);
-				break;
-			case GET:
-				pathItemObject.get(operation);
-				break;
-			case DELETE:
-				pathItemObject.delete(operation);
-				break;
-			case PUT:
-				pathItemObject.put(operation);
-				break;
-			case PATCH:
-				pathItemObject.patch(operation);
-				break;
-			case TRACE:
-				pathItemObject.trace(operation);
-				break;
-			case HEAD:
-				pathItemObject.head(operation);
-				break;
-			case OPTIONS:
-				pathItemObject.options(operation);
-				break;
-			default:
-				// Do nothing here
-				break;
-		}
-	}
-
-
 	private void setPathItemOperation(PathItem pathItemObject, String method, Operation operation) {
 		switch (method) {
 			case POST_METHOD:

springdoc-openapi-common/src/main/java/org/springdoc/core/SecurityParser.java

@@ -162,11 +162,11 @@ public Optional<SecuritySchemePair> getSecurityScheme(
 		if (StringUtils.isNotBlank(securityScheme.ref()))
 			securitySchemeObject.set$ref(securityScheme.ref());
 
-		if (StringUtils.isNotBlank(securityScheme.name()))
+		if (StringUtils.isNotBlank(securityScheme.name())) {
 			key = securityScheme.name();
 			if (SecuritySchemeType.APIKEY.toString().equals(securitySchemeObject.getType().toString()))
 				securitySchemeObject.setName(securityScheme.name());
-
+		}
 		if (StringUtils.isNotBlank(securityScheme.paramName()))
 			securitySchemeObject.setName(securityScheme.paramName());
 

springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocConfiguration.java

@@ -18,7 +18,6 @@
 
 package org.springdoc.core;
 
-import java.lang.reflect.Type;
 import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
@@ -45,7 +44,6 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.LocalVariableTableParameterNameDiscoverer;
-import org.springframework.core.MethodParameter;
 
 import static org.springdoc.core.Constants.SPRINGDOC_CACHE_DISABLED;
 import static org.springdoc.core.Constants.SPRINGDOC_ENABLED;

springdoc-openapi-data-rest/src/main/java/org/springdoc/core/HalProvider.java

@@ -19,7 +19,6 @@
 package org.springdoc.core;
 
 import javax.annotation.PostConstruct;
-import javax.annotation.PreDestroy;
 
 import io.swagger.v3.core.converter.ModelConverters;
 import io.swagger.v3.core.util.Json;

springdoc-openapi-kotlin/pom.xml

@@ -21,13 +21,11 @@
 		<dependency>
 			<groupId>org.jetbrains.kotlin</groupId>
 			<artifactId>kotlin-stdlib-jdk8</artifactId>
-			<version>${kotlin.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
 			<groupId>org.jetbrains.kotlinx</groupId>
 			<artifactId>kotlinx-coroutines-reactor</artifactId>
-			<version>${kotlin-coroutines.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
@@ -43,7 +41,6 @@
 			<plugin>
 				<artifactId>kotlin-maven-plugin</artifactId>
 				<groupId>org.jetbrains.kotlin</groupId>
-				<version>${kotlin.version}</version>
 				<executions>
 					<execution>
 						<id>compile</id>