project review

Author: springdoc

springdoc-openapi-common/pom.xml

@@ -1,4 +1,5 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <artifactId>springdoc-openapi-common</artifactId>
     <name>${project.artifactId}</name>

springdoc-openapi-common/src/main/java/org/springdoc/api/AbstractOpenApiResource.java

@@ -3,20 +3,12 @@
 import com.fasterxml.jackson.annotation.JsonView;
 import io.swagger.v3.core.util.ReflectionUtils;
 import io.swagger.v3.oas.annotations.Hidden;
-import io.swagger.v3.oas.models.Components;
-import io.swagger.v3.oas.models.OpenAPI;
-import io.swagger.v3.oas.models.Operation;
-import io.swagger.v3.oas.models.PathItem;
+import io.swagger.v3.oas.models.*;
 import io.swagger.v3.oas.models.PathItem.HttpMethod;
-import io.swagger.v3.oas.models.Paths;
 import io.swagger.v3.oas.models.responses.ApiResponses;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springdoc.core.AbstractRequestBuilder;
-import org.springdoc.core.AbstractResponseBuilder;
-import org.springdoc.core.MethodAttributes;
-import org.springdoc.core.OpenAPIBuilder;
-import org.springdoc.core.OperationBuilder;
+import org.springdoc.core.*;
 import org.springframework.core.annotation.AnnotationUtils;
 import org.springframework.util.CollectionUtils;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -42,7 +34,7 @@ public abstract class AbstractOpenApiResource {
 
     protected AbstractOpenApiResource(OpenAPIBuilder openAPIBuilder, AbstractRequestBuilder requestBuilder,
                                       AbstractResponseBuilder responseBuilder, OperationBuilder operationParser,
-                                      Optional<List<OpenApiCustomiser>>  openApiCustomisers) {
+                                      Optional<List<OpenApiCustomiser>> openApiCustomisers) {
         super();
         this.openAPIBuilder = openAPIBuilder;
         this.requestBuilder = requestBuilder;
@@ -87,7 +79,7 @@ protected OpenAPI getOpenApi() {
     protected abstract void getPaths(Map<String, Object> findRestControllers);
 
     protected void calculatePath(OpenAPIBuilder openAPIBuilder, HandlerMethod handlerMethod, String operationPath,
-                       Set<RequestMethod> requestMethods) {
+                                 Set<RequestMethod> requestMethods) {
         OpenAPI openAPI = openAPIBuilder.getOpenAPI();
         Components components = openAPIBuilder.getComponents();
         Paths paths = openAPIBuilder.getPaths();

springdoc-openapi-common/src/main/java/org/springdoc/config/SpringDocConfiguration.java

@@ -10,7 +10,7 @@
 public class SpringDocConfiguration {
 
     @Bean
-    LocalVariableTableParameterNameDiscoverer localSpringDocParameterNameDiscoverer(){
+    LocalVariableTableParameterNameDiscoverer localSpringDocParameterNameDiscoverer() {
         return new LocalVariableTableParameterNameDiscoverer();
     }
 }

springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestBuilder.java

@@ -46,8 +46,8 @@ public Operation build(Components components, HandlerMethod handlerMethod, Reque
         LocalVariableTableParameterNameDiscoverer d = parameterBuilder.getLocalSpringDocParameterNameDiscoverer();
         String[] pNames = d.getParameterNames(handlerMethod.getMethod());
         java.lang.reflect.Parameter[] parameters = handlerMethod.getMethod().getParameters();
-        if(pNames == null){
-            pNames =  Arrays.stream(parameters).map(java.lang.reflect.Parameter::getName).toArray(String[]::new);
+        if (pNames == null) {
+            pNames = Arrays.stream(parameters).map(java.lang.reflect.Parameter::getName).toArray(String[]::new);
         }
         RequestBodyInfo requestBodyInfo = new RequestBodyInfo(methodAttributes);
         List<Parameter> operationParameters = (operation.getParameters() != null) ? operation.getParameters()

springdoc-openapi-common/src/main/java/org/springdoc/core/MethodAttributes.java

@@ -23,7 +23,8 @@ public MethodAttributes(String[] methodProducesNew) {
         this.methodProduces = methodProducesNew;
     }
 
-    public MethodAttributes() { }
+    public MethodAttributes() {
+    }
 
     public String[] getClassProduces() {
         return classProduces;

springdoc-openapi-common/src/main/java/org/springdoc/core/ObjectNodeConverter.java

@@ -12,7 +12,7 @@
 import java.util.Iterator;
 
 @SuppressWarnings("rawtypes")
- class ObjectNodeConverter implements ModelConverter {
+class ObjectNodeConverter implements ModelConverter {
 
     @Override
     public Schema resolve(AnnotatedType type, ModelConverterContext context, Iterator<ModelConverter> chain) {

springdoc-openapi-common/src/main/java/org/springdoc/core/OpenAPIBuilder.java

@@ -41,11 +41,11 @@ public class OpenAPIBuilder {
     private final OpenAPI openAPI;
     private final ApplicationContext context;
     private final SecurityParser securityParser;
-    private String serverBaseUrl;
     private final Map<HandlerMethod, String> springdocTags = new HashMap<>();
+    private String serverBaseUrl;
 
-     @SuppressWarnings("WeakerAccess")
-     OpenAPIBuilder(Optional<OpenAPI> openAPI, ApplicationContext context, SecurityParser securityParser) {
+    @SuppressWarnings("WeakerAccess")
+    OpenAPIBuilder(Optional<OpenAPI> openAPI, ApplicationContext context, SecurityParser securityParser) {
         if (openAPI.isPresent()) {
             this.openAPI = openAPI.get();
             if (this.openAPI.getComponents() == null)

springdoc-openapi-common/src/main/java/org/springdoc/core/ParameterInfo.java

@@ -4,8 +4,8 @@
 
 class ParameterInfo {
 
-    private String pName;
     private final java.lang.reflect.Parameter parameter;
+    private String pName;
     private io.swagger.v3.oas.annotations.Parameter parameterDoc;
     private io.swagger.v3.oas.models.parameters.Parameter parameterModel;
     private int index;

springdoc-openapi-common/src/main/java/org/springdoc/core/RequestBodyInfo.java

@@ -8,7 +8,7 @@
 import java.util.Arrays;
 
 @SuppressWarnings("rawtypes")
- class RequestBodyInfo {
+class RequestBodyInfo {
 
     private RequestBody requestBody;
     private Schema mergedSchema;

springdoc-openapi-common/src/main/java/org/springdoc/core/RequestInfo.java

@@ -33,9 +33,11 @@ public String type() {
     public enum ParameterType {
         QUERY_PARAM("query"), HEADER_PARAM("header"), PATH_PARAM("path");
         private final String value;
+
         ParameterType(String s) {
             value = s;
         }
+
         @Override
         public String toString() {
             return value;