code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestService.java

@@ -687,7 +687,7 @@ private String getParamJavadoc(JavadocProvider javadocProvider, MethodParameter
 		final String paramJavadocDescription;
 		if (delegatingMethodParameter.isParameterObject()) {
 			String fieldName;
-			if (pName.contains(DOT))
+			if (StringUtils.isNotEmpty(pName) && pName.contains(DOT))
 				fieldName = StringUtils.substringAfter(pName, DOT);
 			else
 				fieldName = pName;

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseService.java

@@ -217,7 +217,7 @@ public void buildGenericResponse(Components components, Map<String, Object> find
 	 */
 	private boolean isResponseEntityExceptionHandlerMethod(Method m) {
 		if (AnnotatedElementUtils.hasAnnotation(m.getDeclaringClass(), ControllerAdvice.class))
-			return responseEntityExceptionHandlerClass != null && ((responseEntityExceptionHandlerClass.isAssignableFrom(m.getDeclaringClass()) && ReflectionUtils.findMethod(responseEntityExceptionHandlerClass, m.getName(), m.getParameterTypes()) != null));
+			return responseEntityExceptionHandlerClass != null && (responseEntityExceptionHandlerClass.isAssignableFrom(m.getDeclaringClass()) && ReflectionUtils.findMethod(responseEntityExceptionHandlerClass, m.getName(), m.getParameterTypes()) != null);
 		return false;
 	}
 

springdoc-openapi-common/src/main/java/org/springdoc/core/ParameterInfo.java

@@ -77,11 +77,6 @@ public class ParameterInfo {
 	 */
 	private boolean requestPart;
 
-	/**
-	 * The Generic parameter service.
-	 */
-	private GenericParameterService genericParameterService;
-
 	/**
 	 * The constant LOGGER.
 	 */
@@ -95,8 +90,6 @@ public class ParameterInfo {
 	 * @param locale the locale
 	 */
 	public ParameterInfo(String pName, MethodParameter methodParameter, GenericParameterService genericParameterService, Locale locale) {
-		this.genericParameterService = genericParameterService;
-		PropertyResolverUtils propertyResolverUtils = genericParameterService.getPropertyResolverUtils();
 		RequestHeader requestHeader = methodParameter.getParameterAnnotation(RequestHeader.class);
 		RequestParam requestParam = methodParameter.getParameterAnnotation(RequestParam.class);
 		PathVariable pathVar = methodParameter.getParameterAnnotation(PathVariable.class);