code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseBuilder.java

@@ -294,11 +294,10 @@ private void buildApiResponses(Components components, MethodParameter methodPara
 			// API Responses at operation and @ApiResponse annotation
 			for (Map.Entry<String, ApiResponse> entry : apiResponsesOp.entrySet()) {
 				String httpCode = entry.getKey();
-				if (!genericMapResponse.containsKey(httpCode)) {
-					if (!methodAttributes.isMethodOverloaded() || (methodAttributes.isMethodOverloaded() && isValidHttpCode(httpCode, methodParameter))) {
-						ApiResponse apiResponse = entry.getValue();
-						buildApiResponses(components, methodParameter, apiResponsesOp, methodAttributes, httpCode, apiResponse, false);
-					}
+				boolean methodAttributesCondition = !methodAttributes.isMethodOverloaded() || (methodAttributes.isMethodOverloaded() && isValidHttpCode(httpCode, methodParameter));
+				if (!genericMapResponse.containsKey(httpCode) && methodAttributesCondition) {
+					ApiResponse apiResponse = entry.getValue();
+					buildApiResponses(components, methodParameter, apiResponsesOp, methodAttributes, httpCode, apiResponse, false);
 				}
 			}
 		}
@@ -546,20 +545,21 @@ private Map<String, ApiResponse> getGenericMapResponse(Class<?> beanType) {
 	 * @return the boolean
 	 */
 	private boolean isValidHttpCode(String httpCode, MethodParameter methodParameter) {
+		boolean result = false;
 		Set<io.swagger.v3.oas.annotations.responses.ApiResponse> responseSet = getApiResponses(methodParameter.getMethod());
 		if (isHttpCodePresent(httpCode, responseSet))
-			return true;
-		io.swagger.v3.oas.annotations.Operation apiOperation = AnnotatedElementUtils.findMergedAnnotation(methodParameter.getMethod(),
-				io.swagger.v3.oas.annotations.Operation.class);
-		if (apiOperation != null) {
+			result = true;
+		else if (AnnotatedElementUtils.findMergedAnnotation(methodParameter.getMethod(),
+				io.swagger.v3.oas.annotations.Operation.class) != null) {
+			io.swagger.v3.oas.annotations.Operation apiOperation = AnnotatedElementUtils.findMergedAnnotation(methodParameter.getMethod(),
+					io.swagger.v3.oas.annotations.Operation.class);
 			responseSet = new HashSet<>(Arrays.asList(apiOperation.responses()));
 			if (isHttpCodePresent(httpCode, responseSet))
-				return true;
+				result = true;
 		}
-		String httpCode1 = evaluateResponseStatus(methodParameter.getMethod(), methodParameter.getMethod().getClass(), false);
-		if (httpCode.equals(httpCode1))
-			return true;
-		return false;
+		else if (httpCode.equals(evaluateResponseStatus(methodParameter.getMethod(), methodParameter.getMethod().getClass(), false)))
+			result = true;
+		return result;
 	}
 
 	/**

springdoc-openapi-common/src/main/java/org/springdoc/core/GroupedOpenApi.java

@@ -220,6 +220,7 @@ private Builder() {
 		 * @param group the group
 		 * @return the group
 		 * @deprecated Since v1.4.0, GroupedOpenApi.setGroup is marked as deprecated. Use {@link #group(String) } instead.
+		 * will be removed with v1.5.0
 		 */
 		@Deprecated
 		public Builder setGroup(String group) {

springdoc-openapi-data-rest/src/main/java/org/springdoc/data/rest/customisers/DataRestDelegatingMethodParameterCustomizer.java

@@ -249,12 +249,12 @@ public boolean nullable() {
 
 						@Override
 						public boolean readOnly() {
-							return parameter.schema().readOnly();
+							return AccessMode.READ_ONLY.equals(parameter.schema().accessMode());
 						}
 
 						@Override
 						public boolean writeOnly() {
-							return parameter.schema().writeOnly();
+							return AccessMode.WRITE_ONLY.equals(parameter.schema().accessMode());
 						}
 
 						@Override