Prevent bad usage of @ParameterObject for simpleTypes. Fixes #1142

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/DelegatingMethodParameter.java

@@ -97,7 +97,8 @@ public static MethodParameter[] customize(String[] pNames, MethodParameter[] par
 		for (int i = 0; i < parameters.length; ++i) {
 			MethodParameter p = parameters[i];
 			Class<?> paramClass = AdditionalModelsConverter.getReplacement(p.getParameterType());
-			if (p.hasParameterAnnotation(ParameterObject.class) || AnnotatedElementUtils.isAnnotated(paramClass, ParameterObject.class)) {
+
+			if (!MethodParameterPojoExtractor.isSimpleType(paramClass) && (p.hasParameterAnnotation(ParameterObject.class) || AnnotatedElementUtils.isAnnotated(paramClass, ParameterObject.class))) {
 				MethodParameterPojoExtractor.extractFrom(paramClass).forEach(methodParameter -> {
 					optionalDelegatingMethodParameterCustomizer.ifPresent(customizer -> customizer.customize(p, methodParameter));
 					explodedParameters.add(methodParameter);

springdoc-openapi-common/src/main/java/org/springdoc/core/MethodParameterPojoExtractor.java

@@ -220,7 +220,7 @@ private static List<Field> allFieldsOf(Class<?> clazz) {
 	 * @param clazz the clazz
 	 * @return the boolean
 	 */
-	private static boolean isSimpleType(Class<?> clazz) {
+	static boolean isSimpleType(Class<?> clazz) {
 		return SIMPLE_TYPE_PREDICATES.stream().anyMatch(p -> p.test(clazz)) ||
 				SIMPLE_TYPES.stream().anyMatch(c -> c.isAssignableFrom(clazz));
 	}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app154/HelloController.java

@@ -20,7 +20,11 @@
 
 import java.time.Instant;
 
+import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RestController;
 
 @RestController
@@ -31,4 +35,8 @@ public String hello() {
 		return "Hello world at " + Instant.now().toString();
 	}
 
+	@PostMapping(value = "/persons")
+	public void create(@ParameterObject Long id, @RequestBody Object o){
+
+	}
 }

springdoc-openapi-webmvc-core/src/test/resources/results/app154.json

@@ -19,6 +19,38 @@
     }
   ],
   "paths": {
+    "/persons": {
+      "post": {
+        "tags": [
+          "hello-controller"
+        ],
+        "operationId": "create",
+        "requestBody": {
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "id": {
+                    "type": "integer",
+                    "format": "int64"
+                  },
+                  "o": {
+                    "type": "object"
+                  }
+                }
+              }
+            }
+          },
+          "required": true
+        },
+        "responses": {
+          "200": {
+            "description": "OK"
+          }
+        }
+      }
+    },
     "/": {
       "get": {
         "tags": [