Spring Data Rest: RequestBody for POST, PUT, PATCH should be required. fixes #1081

Author: bnasslahsen

springdoc-openapi-data-rest/src/main/java/org/springdoc/data/rest/core/DataRestRequestService.java

@@ -216,6 +216,7 @@ else if (!RequestMethod.GET.equals(requestMethod)) {
 					parameterInfo, requestBodyInfo);
 			requestBuilder.applyBeanValidatorAnnotations(requestBodyInfo.getRequestBody(), parameterAnnotations, methodParameter.isOptional());
 			operation.setRequestBody(requestBodyInfo.getRequestBody());
+			operation.getRequestBody().setRequired(true);
 		}
 	}
 

springdoc-openapi-data-rest/src/test/resources/results/app10.json

@@ -54,7 +54,8 @@
                 "$ref": "#/components/schemas/Account"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "201": {
@@ -158,7 +159,8 @@
                 "$ref": "#/components/schemas/Account"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -234,7 +236,8 @@
                 "$ref": "#/components/schemas/Account"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -324,7 +327,8 @@
                 "$ref": "#/components/schemas/CollectionModelObject"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -410,7 +414,8 @@
                 "$ref": "#/components/schemas/CollectionModelObject"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -547,7 +552,8 @@
                 "$ref": "#/components/schemas/Customer"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "201": {
@@ -685,7 +691,8 @@
                 "$ref": "#/components/schemas/Customer"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -736,7 +743,8 @@
                 "$ref": "#/components/schemas/Customer"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -934,25 +942,6 @@
           }
         }
       },
-      "CollectionModelEntityModelAccount": {
-        "type": "object",
-        "properties": {
-          "_embedded": {
-            "type": "object",
-            "properties": {
-              "accounts": {
-                "type": "array",
-                "items": {
-                  "$ref": "#/components/schemas/EntityModelAccount"
-                }
-              }
-            }
-          },
-          "_links": {
-            "$ref": "#/components/schemas/Links"
-          }
-        }
-      },
       "Customer": {
         "type": "object",
         "properties": {
@@ -987,6 +976,25 @@
           }
         }
       },
+      "CollectionModelEntityModelAccount": {
+        "type": "object",
+        "properties": {
+          "_embedded": {
+            "type": "object",
+            "properties": {
+              "accounts": {
+                "type": "array",
+                "items": {
+                  "$ref": "#/components/schemas/EntityModelAccount"
+                }
+              }
+            }
+          },
+          "_links": {
+            "$ref": "#/components/schemas/Links"
+          }
+        }
+      },
       "EntityModelCustomer": {
         "type": "object",
         "properties": {

springdoc-openapi-data-rest/src/test/resources/results/app11.json

@@ -90,7 +90,8 @@
                 "$ref": "#/components/schemas/Person"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "201": {
@@ -194,7 +195,8 @@
                 "$ref": "#/components/schemas/Person"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -270,7 +272,8 @@
                 "$ref": "#/components/schemas/Person"
               }
             }
-          }
+          },
+          "required": true
         },
         "responses": {
           "200": {
@@ -422,22 +425,14 @@
           }
         }
       },
-      "CollectionModelEntityModelPerson": {
+      "Person": {
         "type": "object",
         "properties": {
-          "_embedded": {
-            "type": "object",
-            "properties": {
-              "people": {
-                "type": "array",
-                "items": {
-                  "$ref": "#/components/schemas/EntityModelPerson"
-                }
-              }
-            }
+          "firstName": {
+            "type": "string"
           },
-          "_links": {
-            "$ref": "#/components/schemas/Links"
+          "lastName": {
+            "type": "string"
           }
         }
       },
@@ -455,14 +450,22 @@
           }
         }
       },
-      "Person": {
+      "CollectionModelEntityModelPerson": {
         "type": "object",
         "properties": {
-          "firstName": {
-            "type": "string"
+          "_embedded": {
+            "type": "object",
+            "properties": {
+              "people": {
+                "type": "array",
+                "items": {
+                  "$ref": "#/components/schemas/EntityModelPerson"
+                }
+              }
+            }
           },
-          "lastName": {
-            "type": "string"
+          "_links": {
+            "$ref": "#/components/schemas/Links"
           }
         }
       },