code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseService.java

@@ -47,8 +47,6 @@
 import io.swagger.v3.oas.models.responses.ApiResponses;
 import org.apache.commons.lang3.ArrayUtils;
 import org.apache.commons.lang3.StringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springdoc.core.providers.JavadocProvider;
 
 import org.springframework.core.MethodParameter;

springdoc-openapi-common/src/main/java/org/springdoc/core/OpenAPIService.java

@@ -57,6 +57,7 @@
 import org.slf4j.LoggerFactory;
 import org.springdoc.core.customizers.OpenApiBuilderCustomizer;
 import org.springdoc.core.customizers.ServerBaseUrlCustomizer;
+
 import org.springframework.beans.BeansException;
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.boot.autoconfigure.AutoConfigurationPackages;

springdoc-openapi-common/src/main/java/org/springdoc/core/PropertyResolverUtils.java

@@ -163,7 +163,7 @@ public Info resolveProperties(Info info, Locale locale) {
 	 * @return the schema
 	 */
 	@SuppressWarnings("unchecked")
-	public Schema resolveProperties(Schema schema, Locale locale) {
+	public Schema resolveProperties(Schema<?> schema, Locale locale) {
 		resolveProperty(schema::getName, schema::name, this, locale);
 		resolveProperty(schema::getTitle, schema::title, this, locale);
 		resolveProperty(schema::getDescription, schema::description, this, locale);

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app30/QUser.java

@@ -1,13 +1,13 @@
 package test.org.springdoc.api.app30;
 
+import javax.annotation.Generated;
+
 import com.querydsl.core.types.Path;
 import com.querydsl.core.types.PathMetadata;
 import com.querydsl.core.types.dsl.EntityPathBase;
 import com.querydsl.core.types.dsl.NumberPath;
 import com.querydsl.core.types.dsl.StringPath;
 
-import javax.annotation.Generated;
-
 import static com.querydsl.core.types.PathMetadataFactory.forVariable;
 
 

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app181/AbstractParameterObject.java

@@ -1,8 +1,5 @@
 package test.org.springdoc.api.app181;
 
-import io.swagger.v3.oas.annotations.Parameter;
-import io.swagger.v3.oas.annotations.media.Schema;
-
 public class AbstractParameterObject<T> {
 
 	int primitiveBaseField;

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app182/HelloController.java

@@ -21,15 +21,13 @@
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.media.Content;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
-import org.springdoc.api.annotations.ParameterObject;
+
 import org.springframework.http.HttpStatus;
-import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.ResponseStatus;
 import org.springframework.web.bind.annotation.RestController;
-import test.org.springdoc.api.app181.ConcreteParameterObject;
 
 @RestController
 public class HelloController<T> {

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app182/SpringDocApp182Test.java

@@ -18,9 +18,10 @@
 
 package test.org.springdoc.api.app182;
 
-import org.springframework.boot.autoconfigure.SpringBootApplication;
 import test.org.springdoc.api.AbstractSpringDocTest;
 
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
 
 /**
  * Copy of 124 without RestControllerAdvice class