project review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/DelegatingMethodParameter.java

@@ -12,6 +12,7 @@
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
 import java.util.stream.Stream;
@@ -29,7 +30,7 @@
  * @author zarebski.m
  */
 class DelegatingMethodParameter extends MethodParameter {
-	private volatile MethodParameter delegate;
+	private MethodParameter delegate;
 
 	private Annotation[] additionalParameterAnnotations;
 
@@ -153,4 +154,22 @@ static MethodParameter fromGetterOfField(Class<?> paramClass, Field field) {
 			return null;
 		}
 	}
+
+	@Override
+	public boolean equals(Object o) {
+		if (this == o) return true;
+		if (o == null || getClass() != o.getClass()) return false;
+		if (!super.equals(o)) return false;
+		DelegatingMethodParameter that = (DelegatingMethodParameter) o;
+		return Objects.equals(delegate, that.delegate) &&
+				Arrays.equals(additionalParameterAnnotations, that.additionalParameterAnnotations) &&
+				Objects.equals(parameterName, that.parameterName);
+	}
+
+	@Override
+	public int hashCode() {
+		int result = Objects.hash(super.hashCode(), delegate, parameterName);
+		result = 31 * result + Arrays.hashCode(additionalParameterAnnotations);
+		return result;
+	}
 }

springdoc-openapi-data-rest/src/main/java/org/springdoc/core/converters/PageableAsQueryParam.java

@@ -49,6 +49,7 @@
 		+ "Default sort order is ascending. " + "Multiple sort criteria are supported."
 		, name = "sort"
 		, content = @Content(array = @ArraySchema(schema = @Schema(type = "string"))))
-public @interface PageableAsQueryParam {
+public @interface
+PageableAsQueryParam {
 
 }