Skip to content

Commit dde76f0

Browse files
committed
Remove 'org.apache.geode:geode-membership' and 'org.apache.geode:geode-tcp-server' provided dependency declarations.
Add Javadoc to the GemFireUtilsTests to remove use of internal Apache Geode APIs (AbstractRegion).
1 parent d83f869 commit dde76f0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

spring-session-data-geode/spring-session-data-geode.gradle

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,10 @@ dependencies {
2222

2323
provided "javax.servlet:javax.servlet-api"
2424

25-
// TODO: Remove dependency declarations when all internal Apache Geode API usage is removed; Only required by tests!
25+
// TODO: Remove dependency declarations when all internal Apache Geode API usage is removed; Only required by test,
26+
// and specifically, the GemFireUtilsTests! :P
2627
provided "org.apache.geode:geode-logging:$apacheGeodeVersion"
27-
provided "org.apache.geode:geode-membership:$apacheGeodeVersion" // Need for Geode Serialization
2828
provided "org.apache.geode:geode-serialization:$apacheGeodeVersion" // Need for Geode Serialization
29-
provided "org.apache.geode:geode-tcp-server:$apacheGeodeVersion" // Need for Geode Serialization
3029

3130
testCompile "org.assertj:assertj-core"
3231
testCompile "junit:junit"

spring-session-data-geode/src/test/java/org/springframework/session/data/gemfire/support/GemFireUtilsTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ public void clientRegionWithPoolIsNonLocalClientRegion() {
175175

176176
@Test
177177
@SuppressWarnings("rawtypes")
178+
// TODO: Remove use of Apache Geode internal API (AbstractRegion).
178179
public void clientRegionWithServerProxyIsNonLocalClientRegion() {
179180

180181
ClientCache mockClientCache = mock(ClientCache.class);
@@ -198,6 +199,7 @@ public void clientRegionWithServerProxyIsNonLocalClientRegion() {
198199

199200
@Test
200201
@SuppressWarnings("rawtypes")
202+
// TODO: Remove use of Apache Geode internal API (AbstractRegion).
201203
public void clientRegionWithNoPoolAndNoServerProxyIsNotNonLocalClientRegion() {
202204

203205
ClientCache mockClientCache = mock(ClientCache.class);
@@ -242,6 +244,7 @@ public void nonClientRegionWithPoolIsNotNonLocalClientRegion() {
242244

243245
@Test
244246
@SuppressWarnings("rawtypes")
247+
// TODO: Remove use of Apache Geode internal API (AbstractRegion).
245248
public void peerRegionWithServerProxyIsNotNonLocalClientRegion() {
246249

247250
Cache mockPeerCache = mock(Cache.class);

0 commit comments

Comments
 (0)