Skip to content

Create SHA-1 MessageDigest for every new check request in Compromised Password Checker #18235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −14
Open

Create SHA-1 MessageDigest for every new check request in Compromised Password Checker #18235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd30a7
gh-18234: Create SHA-1 MessageDigest for every new check request
garvit-joshi Nov 29, 2025
4bf9f00
gh-18234: Create SHA-1 MessageDigest for every new check request
garvit-joshi Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...gframework/security/web/authentication/password/HaveIBeenPwnedRestApiPasswordChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,15 @@ public final class HaveIBeenPwnedRestApiPasswordChecker implements CompromisedPa

private final Log logger = LogFactory.getLog(getClass());

private final MessageDigest sha1Digest;

private RestClient restClient = RestClient.builder().baseUrl(API_URL).build();

public HaveIBeenPwnedRestApiPasswordChecker() {
this.sha1Digest = getSha1Digest();
}

@Override
public CompromisedPasswordDecision check(@Nullable String password) {
if (password == null) {
return new CompromisedPasswordDecision(false);
}
byte[] hash = this.sha1Digest.digest(password.getBytes(StandardCharsets.UTF_8));
MessageDigest sha1Digest = getSha1Digest();
byte[] hash = sha1Digest.digest(password.getBytes(StandardCharsets.UTF_8));
String encoded = new String(Hex.encode(hash)).toUpperCase(Locale.ROOT);
String prefix = encoded.substring(0, PREFIX_LENGTH);
String suffix = encoded.substring(PREFIX_LENGTH);
Expand Down
11 changes: 4 additions & 7 deletions ...rk/security/web/authentication/password/HaveIBeenPwnedRestApiReactivePasswordChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@ public class HaveIBeenPwnedRestApiReactivePasswordChecker implements ReactiveCom

private WebClient webClient = WebClient.builder().baseUrl(API_URL).build();

private final MessageDigest sha1Digest;

public HaveIBeenPwnedRestApiReactivePasswordChecker() {
this.sha1Digest = getSha1Digest();
}

@Override
public Mono<CompromisedPasswordDecision> check(@Nullable String password) {
return getHash(password).map((hash) -> new String(Hex.encode(hash)))
Expand Down Expand Up @@ -98,7 +92,10 @@ public void setWebClient(WebClient webClient) {

private Mono<byte[]> getHash(@Nullable String rawPassword) {
return Mono.justOrEmpty(rawPassword)
.map((password) -> this.sha1Digest.digest(password.getBytes(StandardCharsets.UTF_8)))
.map((password) -> {
MessageDigest sha1Digest = getSha1Digest();
return sha1Digest.digest(password.getBytes(StandardCharsets.UTF_8));
})
.subscribeOn(Schedulers.boundedElastic())
.publishOn(Schedulers.parallel());
}
Expand Down