Skip to content

Commit 8f34a67

Browse files
committed
Polish core retry internals
1 parent 9849094 commit 8f34a67

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

spring-core/src/main/java/org/springframework/core/retry/RetryException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
public class RetryException extends Exception {
4545

4646
@Serial
47-
private static final long serialVersionUID = 5439915454935047936L;
47+
private static final long serialVersionUID = 1L;
4848

4949

5050
/**

spring-core/src/main/java/org/springframework/core/retry/RetryTemplate.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.core.retry;
1818

19+
import java.io.Serial;
1920
import java.util.ArrayDeque;
2021
import java.util.Deque;
2122

@@ -148,7 +149,7 @@ public RetryListener getRetryListener() {
148149
.formatted(retryableName));
149150
// Retry process starts here
150151
BackOffExecution backOffExecution = this.retryPolicy.getBackOff().start();
151-
Deque<Throwable> exceptions = new ArrayDeque<>();
152+
Deque<Throwable> exceptions = new ArrayDeque<>(4);
152153
exceptions.add(initialException);
153154

154155
Throwable lastException = initialException;
@@ -200,8 +201,10 @@ public RetryListener getRetryListener() {
200201
}
201202
}
202203

204+
203205
private static class RetryInterruptedException extends RetryException {
204206

207+
@Serial
205208
private static final long serialVersionUID = 1L;
206209

207210

@@ -213,7 +216,6 @@ private static class RetryInterruptedException extends RetryException {
213216
public int getRetryCount() {
214217
return (getSuppressed().length - 1);
215218
}
216-
217219
}
218220

219221
}

spring-core/src/main/java/org/springframework/core/retry/support/CompositeRetryListener.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public class CompositeRetryListener implements RetryListener {
4646

4747
/**
4848
* Create a new {@code CompositeRetryListener}.
49+
* @see #addListener(RetryListener)
4950
*/
5051
public CompositeRetryListener() {
5152
}
@@ -56,7 +57,7 @@ public CompositeRetryListener() {
5657
* @param listeners the list of delegate listeners to register; must not be empty
5758
*/
5859
public CompositeRetryListener(List<RetryListener> listeners) {
59-
Assert.notEmpty(listeners, "RetryListener List must not be empty");
60+
Assert.notEmpty(listeners, "RetryListener list must not be empty");
6061
this.listeners.addAll(listeners);
6162
}
6263

0 commit comments

Comments
 (0)