Skip to content

Commit 0c61ac9

Browse files
committed
Add missing @⁠Override annotations
... and suppress "serial" warnings
1 parent f504d05 commit 0c61ac9

File tree

42 files changed

+44
-5
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+44
-5
lines changed

spring-expression/src/main/java/org/springframework/expression/ExpressionException.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,11 @@ public final int getPosition() {
117117

118118
/**
119119
* Return the exception message.
120-
* As of Spring 4.0, this method returns the same result as {@link #toDetailedString()}.
120+
* <p>This method returns the same result as {@link #toDetailedString()}.
121121
* @see #getSimpleMessage()
122122
* @see java.lang.Throwable#getMessage()
123123
*/
124+
@Override
124125
public String getMessage() {
125126
return toDetailedString();
126127
}

spring-jms/src/main/java/org/springframework/jms/core/DefaultJmsClient.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,12 @@ void setMessagePostProcessor(MessagePostProcessor messagePostProcessor) {
7070
}
7171

7272

73+
@Override
7374
public OperationSpec destination(Destination destination) {
7475
return new DefaultOperationSpec(destination);
7576
}
7677

78+
@Override
7779
public OperationSpec destination(String destinationName) {
7880
return new DefaultOperationSpec(destinationName);
7981
}

spring-messaging/src/test/java/org/springframework/messaging/core/MessageSendingTemplateTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class MessageSendingTemplateTests {
5050

5151
private final TestMessagePostProcessor postProcessor = new TestMessagePostProcessor();
5252

53+
@SuppressWarnings("serial")
5354
private final Map<String, Object> headers = new HashMap<>() {{
5455
put("key", "value");
5556
}};

spring-orm/src/main/java/org/springframework/orm/jpa/hibernate/LocalSessionFactoryBuilder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ public LocalSessionFactoryBuilder setEntityTypeFilters(TypeFilter... entityTypeF
284284
* @see #addPackage
285285
* @see #scanPackages
286286
*/
287+
@Override
287288
public LocalSessionFactoryBuilder addPackages(String... annotatedPackages) {
288289
for (String annotatedPackage : annotatedPackages) {
289290
addPackage(annotatedPackage);

spring-test/src/main/java/org/springframework/mock/web/MockHttpServletResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ public void sendRedirect(String url) throws IOException {
642642
sendRedirect(url, HttpServletResponse.SC_MOVED_TEMPORARILY, true);
643643
}
644644

645-
// @Override - on Servlet 6.1
645+
@Override
646646
public void sendRedirect(String url, int sc, boolean clearBuffer) throws IOException {
647647
Assert.state(!isCommitted(), "Cannot send redirect - response is already committed");
648648
Assert.notNull(url, "Redirect URL must not be null");

spring-test/src/main/java/org/springframework/test/web/servlet/client/DefaultRestTestClientBuilder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ public AbstractMockMvcSetupBuilder(M mockMvcBuilder) {
173173
this.mockMvcBuilder = mockMvcBuilder;
174174
}
175175

176+
@Override
176177
public <T extends S> T configureServer(Consumer<M> consumer) {
177178
consumer.accept(this.mockMvcBuilder);
178179
return self();

spring-test/src/test/java/org/springframework/test/web/servlet/client/samples/bind/FilterTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class FilterTests {
4141
@Test
4242
void filter() {
4343

44+
@SuppressWarnings("serial")
4445
Filter filter = new HttpFilter() {
4546
@Override
4647
protected void doFilter(HttpServletRequest req, HttpServletResponse res, FilterChain chain) throws IOException {

spring-tx/src/test/java/org/springframework/transaction/interceptor/AbstractTransactionAspectTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,7 @@ void noRollbackOnUncheckedExceptionWithRollbackException() throws Throwable {
370370
protected void doTestRollbackOnException(
371371
final Exception ex, final boolean shouldRollback, boolean rollbackException) throws Exception {
372372

373+
@SuppressWarnings("serial")
373374
TransactionAttribute txatt = new DefaultTransactionAttribute() {
374375
@Override
375376
public boolean rollbackOn(Throwable t) {

spring-web/src/main/java/org/springframework/http/client/reactive/JdkResponseCookieParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
import org.springframework.http.ResponseCookie;
2525

26-
2726
/**
2827
* Parser that delegates to {@link java.net.HttpCookie#parse(String)} for parsing,
2928
* but also extracts and sets {@code sameSite}.
@@ -39,6 +38,7 @@ final class JdkResponseCookieParser implements ResponseCookie.Parser {
3938
/**
4039
* Parse the given headers.
4140
*/
41+
@Override
4242
public List<ResponseCookie> parse(String header) {
4343
Matcher matcher = SAME_SITE_PATTERN.matcher(header);
4444
String sameSite = (matcher.matches() ? matcher.group(1) : null);

spring-web/src/main/java/org/springframework/web/accept/DefaultApiVersionStrategy.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ public Comparable<?> parseVersion(String version) {
163163
return this.versionParser.parseVersion(version);
164164
}
165165

166+
@Override
166167
public void validateVersion(@Nullable Comparable<?> requestVersion, HttpServletRequest request)
167168
throws MissingApiVersionException, InvalidApiVersionException {
168169

0 commit comments

Comments
 (0)