Unifying GitHub references to GH-nnn.

schauder · schauder · commit 884332871ea8 · 2021-07-02T11:07:27.000+02:00
Original pull request #903 See #578
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverterUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverterUnitTests.java
@@ -131,7 +131,7 @@ void conversionOfDateLikeValueAndBackYieldsOriginalValue() {
 
 	}
 
-	@Test // #945
+	@Test // GH-945
 	void conversionOfPrimitiveArrays() {
 
 		int[] ints = { 1, 2, 3, 4, 5 };
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java
@@ -193,7 +193,7 @@ public void considersConfiguredWriteConverterForIdValueObjectsWhichReferencedInO
 		assertThat(paramSourceCaptor.getValue().getValue("DUMMYENTITYROOT")).isEqualTo(rawId);
 	}
 
-	@Test // #933
+	@Test // GH-933
 	public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {
 
 		Object generatedId = accessStrategy.insert(new DummyEntity(ORIGINAL_ID), DummyEntity.class, Identifier.from(additionalParameters));
@@ -204,7 +204,7 @@ public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {
 				paramSourceCaptor.capture());
 	}
 
-	@Test // #933
+	@Test // GH-933
 	public void insertWithUndefinedIdRetrievesGeneratedKeys() {
 
 		when(namedJdbcOperations.update(any(), any(), any()))
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/JdbcCustomConversionsUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/JdbcCustomConversionsUnitTests.java
@@ -27,7 +27,7 @@
  */
 class JdbcCustomConversionsUnitTests {
 
-	@Test // #937
+	@Test // GH-937
 	void registersNonDateDefaultConverter() {
 
 		JdbcCustomConversions conversions = new JdbcCustomConversions();
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcDb2DialectUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcDb2DialectUnitTests.java
@@ -32,7 +32,7 @@
  */
 class JdbcDb2DialectUnitTests {
 
-	@Test // #974
+	@Test // GH-974
 	void testCustomConversions() {
 
 		JdbcCustomConversions customConversions = new JdbcCustomConversions(
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcMySqlDialectUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcMySqlDialectUnitTests.java
@@ -32,7 +32,7 @@
  */
 class JdbcMySqlDialectUnitTests {
 
-	@Test // #974
+	@Test // GH-974
 	void testCustomConversions() {
 
 		JdbcCustomConversions customConversions = new JdbcCustomConversions(
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/BasicJdbcPersistentPropertyUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/BasicJdbcPersistentPropertyUnitTests.java
@@ -96,7 +96,7 @@ public void detectsKeyColumnOverrideNameFromMappedCollectionAnnotation() {
 		assertThat(listProperty.getReverseColumnName(path)).isEqualTo(quoted("override_id"));
 	}
 
-	@Test // #938
+	@Test // GH-938
 	void considersAggregateReferenceAnAssociation() {
 
 		RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java
@@ -402,7 +402,7 @@ public void countByQueryDerivation() {
 		assertThat(repository.countByName(one.getName())).isEqualTo(2);
 	}
 
-	@Test // #945
+	@Test // GH-945
 	@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
 	public void usePrimitiveArrayAsArgument() {
 		assertThat(repository.unnestPrimitive(new int[] { 1, 2, 3 })).containsExactly(1, 2, 3);
@@ -439,7 +439,7 @@ public void sliceByNameShouldReturnCorrectResult() {
 		assertThat(slice.hasNext()).isTrue();
 	}
 
-	@Test // #935
+	@Test // GH-935
 	public void queryByOffsetDateTime() {
 
 		Instant now = createDummyBeforeAndAfterNow();
@@ -450,7 +450,7 @@ public void queryByOffsetDateTime() {
 		assertThat(entities).extracting(DummyEntity::getName).containsExactly("second");
 	}
 
-	@Test // #971
+	@Test // GH-971
 	public void stringQueryProjectionShouldReturnProjectedEntities() {
 
 		repository.save(createDummyEntity());
@@ -461,7 +461,7 @@ public void stringQueryProjectionShouldReturnProjectedEntities() {
 		assertThat(result.get(0).getName()).isEqualTo("Entity Name");
 	}
 
-	@Test // #971
+	@Test // GH-971
 	public void stringQueryProjectionShouldReturnDtoProjectedEntities() {
 
 		repository.save(createDummyEntity());
@@ -472,7 +472,7 @@ public void stringQueryProjectionShouldReturnDtoProjectedEntities() {
 		assertThat(result.get(0).getName()).isEqualTo("Entity Name");
 	}
 
-	@Test // #971
+	@Test // GH-971
 	public void partTreeQueryProjectionShouldReturnProjectedEntities() {
 
 		repository.save(createDummyEntity());
@@ -483,7 +483,7 @@ public void partTreeQueryProjectionShouldReturnProjectedEntities() {
 		assertThat(result.get(0).getName()).isEqualTo("Entity Name");
 	}
 
-	@Test // #971
+	@Test // GH-971
 	public void pageQueryProjectionShouldReturnProjectedEntities() {
 
 		repository.save(createDummyEntity());
@@ -494,14 +494,14 @@ public void pageQueryProjectionShouldReturnProjectedEntities() {
 		assertThat(result.getContent().get(0).getName()).isEqualTo("Entity Name");
 	}
 
-	@Test // #974
+	@Test // GH-974
 	@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
 	void intervalCalculation() {
 
 		repository.updateWithIntervalCalculation(23L, LocalDateTime.now());
 	}
 
-	@Test // #908
+	@Test // GH-908
 	void derivedQueryWithBooleanLiteralFindsCorrectValues() {
 
 		repository.save(createDummyEntity());
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfigurationIntegrationTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfigurationIntegrationTests.java
@@ -70,7 +70,7 @@ void configuresInfrastructureComponents() {
 		}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
 	}
 
-	@Test // #975
+	@Test // GH-975
 	void registersSimpleTypesFromCustomConversions() {
 
 		assertApplicationContext(context -> {
@@ -84,7 +84,7 @@ void registersSimpleTypesFromCustomConversions() {
 		}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
 	}
 
-	@Test // #908
+	@Test // GH-908
 	void userProvidedConversionsOverwriteDialectSpecificConversions() {
 
 		assertApplicationContext(applicationContext -> {
diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/query/PartTreeJdbcQueryUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/query/PartTreeJdbcQueryUnitTests.java
@@ -117,7 +117,7 @@ public void createsQueryToFindAllEntitiesByStringAttribute() throws Exception {
 		assertThat(query.getQuery()).isEqualTo(BASE_SELECT + " WHERE " + TABLE + ".\"FIRST_NAME\" = :first_name");
 	}
 
-	@Test // #971
+	@Test // GH-971
 	public void createsQueryToFindAllEntitiesByProjectionAttribute() throws Exception {
 
 		when(returnedType.needsCustomConstruction()).thenReturn(true);
diff --git a/spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/ConditionsUnitTests.java b/spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/ConditionsUnitTests.java
@@ -24,7 +24,7 @@
  */
 class ConditionsUnitTests {
 
-	@Test // #916
+	@Test // GH-916
 	void notInOfColumnAndExpression() {
 
 		Table table = Table.create("t");
diff --git a/spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java b/spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java
@@ -233,7 +233,7 @@ public void shouldRenderNotIn() {
 		assertThat(sql).endsWith("WHERE my_table.left NOT IN (my_table.right)");
 	}
 
-	@Test // #907
+	@Test // GH-907
 	public void shouldRenderJust() {
 
 		String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
@@ -243,7 +243,7 @@ public void shouldRenderJust() {
 		assertThat(sql).endsWith("WHERE sql");
 	}
 
-	@Test // #907
+	@Test // GH-907
 	public void shouldRenderMultipleJust() {
 
 		String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
diff --git a/spring-data-relational/src/test/java/org/springframework/data/relational/repository/query/RelationalExampleMapperTests.java b/spring-data-relational/src/test/java/org/springframework/data/relational/repository/query/RelationalExampleMapperTests.java
@@ -49,7 +49,7 @@ public void before() {
 		exampleMapper = new RelationalExampleMapper(new RelationalMappingContext());
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithId() {
 
 		Person person = new Person();
@@ -64,7 +64,7 @@ void queryByExampleWithId() {
 				.hasValue("(id = 'id1')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstname() {
 
 		Person person = new Person();
@@ -79,7 +79,7 @@ void queryByExampleWithFirstname() {
 				.hasValue("(firstname = 'Frodo')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameAndLastname() {
 
 		Person person = new Person();
@@ -95,7 +95,7 @@ void queryByExampleWithFirstnameAndLastname() {
 				.hasValue("(firstname = 'Frodo') AND (lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithNullMatchingLastName() {
 
 		Person person = new Person();
@@ -111,7 +111,7 @@ void queryByExampleWithNullMatchingLastName() {
 				.hasValue("(lastname IS NULL OR lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithNullMatchingFirstnameAndLastname() {
 
 		Person person = new Person();
@@ -128,7 +128,7 @@ void queryByExampleWithNullMatchingFirstnameAndLastname() {
 				.hasValue("(firstname IS NULL OR firstname = 'Bilbo') AND (lastname IS NULL OR lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() {
 
 		Person person = new Person();
@@ -145,7 +145,7 @@ void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() {
 				.hasValue("(lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() {
 
 		Person person = new Person();
@@ -162,7 +162,7 @@ void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() {
 				.hasValue("(lastname IS NULL OR lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() {
 
 		Person person = new Person();
@@ -178,7 +178,7 @@ void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() {
 				.hasValue("(firstname LIKE 'Fro%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() {
 
 		Person person = new Person();
@@ -194,7 +194,7 @@ void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() {
 				.hasValue("(firstname LIKE '%do')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingContaining() {
 
 		Person person = new Person();
@@ -210,7 +210,7 @@ void queryByExampleWithFirstnameWithStringMatchingContaining() {
 				.hasValue("(firstname LIKE '%do%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingRegEx() {
 
 		Person person = new Person();
@@ -223,7 +223,7 @@ void queryByExampleWithFirstnameWithStringMatchingRegEx() {
 				.withMessageContaining("REGEX is not supported!");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() {
 
 		Person person = new Person();
@@ -239,7 +239,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() {
 				.hasValue("(firstname LIKE '%do')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() {
 
 		Person person = new Person();
@@ -255,7 +255,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() {
 				.hasValue("(firstname LIKE 'Fro%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() {
 
 		Person person = new Person();
@@ -271,7 +271,7 @@ void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() {
 				.hasValue("(firstname LIKE '%do%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull() {
 
 		Person person = new Person();
@@ -287,7 +287,7 @@ void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull()
 				.hasValue("(firstname IS NULL OR firstname LIKE 'Fro%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() {
 
 		Person person = new Person();
@@ -303,7 +303,7 @@ void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() {
 				.hasValue("(firstname IS NULL OR firstname LIKE '%do')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameIgnoreCaseFieldLevel() {
 
 		Person person = new Person();
@@ -321,7 +321,7 @@ void queryByExampleWithFirstnameIgnoreCaseFieldLevel() {
 		assertThat(example.getMatcher().getPropertySpecifiers().getForPath("firstname").getIgnoreCase()).isTrue();
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() {
 
 		Person person = new Person();
@@ -337,7 +337,7 @@ void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() {
 				.hasValue("(firstname IS NULL OR firstname LIKE '%do%')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameIgnoreCase() {
 
 		Person person = new Person();
@@ -355,7 +355,7 @@ void queryByExampleWithFirstnameIgnoreCase() {
 		assertThat(example.getMatcher().isIgnoreCaseEnabled()).isTrue();
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleWithFirstnameOrLastname() {
 
 		Person person = new Person();
@@ -372,7 +372,7 @@ void queryByExampleWithFirstnameOrLastname() {
 				.hasValue("(firstname = 'Frodo') OR (lastname = 'Baggins')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleEvenHandlesInvisibleFields() {
 
 		Person person = new Person();
@@ -388,7 +388,7 @@ void queryByExampleEvenHandlesInvisibleFields() {
 				.hasValue("(firstname = 'Frodo') AND (secret = 'I have the ring!')");
 	}
 
-	@Test // #929
+	@Test // GH-929
 	void queryByExampleSupportsPropertyTransforms() {
 
 		Person person = new Person();

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ void conversionOfDateLikeValueAndBackYieldsOriginalValue() {`
`131`	`131`
`132`	`132`	`}`
`133`	`133`
`134`		`- @Test // #945`
	`134`	`+ @Test // GH-945`
`135`	`135`	`void conversionOfPrimitiveArrays() {`
`136`	`136`
`137`	`137`	`int[] ints = { 1, 2, 3, 4, 5 };`
Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ public void considersConfiguredWriteConverterForIdValueObjectsWhichReferencedInO`
`193`	`193`	`assertThat(paramSourceCaptor.getValue().getValue("DUMMYENTITYROOT")).isEqualTo(rawId);`
`194`	`194`	`}`
`195`	`195`
`196`		`- @Test // #933`
	`196`	`+ @Test // GH-933`
`197`	`197`	`public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {`
`198`	`198`
`199`	`199`	`Object generatedId = accessStrategy.insert(new DummyEntity(ORIGINAL_ID), DummyEntity.class, Identifier.from(additionalParameters));`
`@@ -204,7 +204,7 @@ public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {`
`204`	`204`	`paramSourceCaptor.capture());`
`205`	`205`	`}`
`206`	`206`
`207`		`- @Test // #933`
	`207`	`+ @Test // GH-933`
`208`	`208`	`public void insertWithUndefinedIdRetrievesGeneratedKeys() {`
`209`	`209`
`210`	`210`	`when(namedJdbcOperations.update(any(), any(), any()))`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public void detectsKeyColumnOverrideNameFromMappedCollectionAnnotation() {`
`96`	`96`	`assertThat(listProperty.getReverseColumnName(path)).isEqualTo(quoted("override_id"));`
`97`	`97`	`}`
`98`	`98`
`99`		`- @Test // #938`
	`99`	`+ @Test // GH-938`
`100`	`100`	`void considersAggregateReferenceAnAssociation() {`
`101`	`101`
`102`	`102`	`RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ void configuresInfrastructureComponents() {`
`70`	`70`	`}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);`
`71`	`71`	`}`
`72`	`72`
`73`		`- @Test // #975`
	`73`	`+ @Test // GH-975`
`74`	`74`	`void registersSimpleTypesFromCustomConversions() {`
`75`	`75`
`76`	`76`	`assertApplicationContext(context -> {`
`@@ -84,7 +84,7 @@ void registersSimpleTypesFromCustomConversions() {`
`84`	`84`	`}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);`
`85`	`85`	`}`
`86`	`86`
`87`		`- @Test // #908`
	`87`	`+ @Test // GH-908`
`88`	`88`	`void userProvidedConversionsOverwriteDialectSpecificConversions() {`
`89`	`89`
`90`	`90`	`assertApplicationContext(applicationContext -> {`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public void createsQueryToFindAllEntitiesByStringAttribute() throws Exception {`
`117`	`117`	`assertThat(query.getQuery()).isEqualTo(BASE_SELECT + " WHERE " + TABLE + ".\"FIRST_NAME\" = :first_name");`
`118`	`118`	`}`
`119`	`119`
`120`		`- @Test // #971`
	`120`	`+ @Test // GH-971`
`121`	`121`	`public void createsQueryToFindAllEntitiesByProjectionAttribute() throws Exception {`
`122`	`122`
`123`	`123`	`when(returnedType.needsCustomConstruction()).thenReturn(true);`