Polishing.

Added `@author` tags.
Undo the change in behaviour of getReference(IdentifierProcessing).

See #1110
Original pull request #1458

Author: schauder

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/IdGeneratingBatchInsertStrategy.java

@@ -32,6 +32,7 @@
  * not support id generation for batch operations, this implementation falls back to performing the inserts serially.
  *
  * @author Chirag Tailor
+ * @author Kurt Niemi
  * @since 2.4
  */
 class IdGeneratingBatchInsertStrategy implements BatchInsertStrategy {

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/IdGeneratingInsertStrategy.java

@@ -33,6 +33,7 @@
  * An {@link InsertStrategy} that expects an id to be generated from the insert.
  *
  * @author Chirag Tailor
+ * @author Kurt Niemi
  * @since 2.4
  */
 class IdGeneratingInsertStrategy implements InsertStrategy {
@@ -84,8 +85,7 @@ public Object execute(String sql, SqlParameterSource sqlParameterSource) {
 	}
 
 	private String[] getKeyColumnNames() {
-		return Optional.ofNullable(idColumn)
-				.map(idColumn -> new String[] { idColumn.getReference() })
+		return Optional.ofNullable(idColumn).map(idColumn -> new String[] { idColumn.getReference() })
 				.orElse(new String[0]);
 	}
 }

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcBackReferencePropertyValueProvider.java

@@ -25,6 +25,7 @@
  * the value in the resultset under which other entities refer back to it.
  *
  * @author Jens Schauder
+ * @author Kurt Niemi
  * @since 2.0
  */
 class JdbcBackReferencePropertyValueProvider implements PropertyValueProvider<RelationalPersistentProperty> {
@@ -49,8 +50,7 @@ class JdbcBackReferencePropertyValueProvider implements PropertyValueProvider<Re
 
 	@Override
 	public <T> T getPropertyValue(RelationalPersistentProperty property) {
-		return (T) resultSet
-				.getObject(basePath.extendBy(property).getReverseColumnNameAlias().getReference());
+		return (T) resultSet.getObject(basePath.extendBy(property).getReverseColumnNameAlias().getReference());
 	}
 
 	public JdbcBackReferencePropertyValueProvider extendBy(RelationalPersistentProperty property) {

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/JdbcPropertyValueProvider.java

@@ -24,6 +24,7 @@
  * {@link PropertyValueProvider} obtaining values from a {@link ResultSetAccessor}.
  *
  * @author Jens Schauder
+ * @author Kurt Niemi
  * @since 2.0
  */
 class JdbcPropertyValueProvider implements PropertyValueProvider<RelationalPersistentProperty> {

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGenerator.java

@@ -57,6 +57,7 @@
  * @author Diego Krupitza
  * @author Hari Ohm Prasath
  * @author Viktor Ardelean
+ * @author Kurt Niemi
  */
 class SqlGenerator {
 

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlIdentifierParameterSource.java

@@ -30,6 +30,7 @@
  * {@link SqlIdentifier} instead of {@link String} for names.
  *
  * @author Jens Schauder
+ * @author Kurt Niemi
  * @since 2.0
  */
 class SqlIdentifierParameterSource extends AbstractSqlParameterSource {

spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/H2Dialect.java

@@ -27,6 +27,7 @@
  * @author Mark Paluch
  * @author Jens Schauder
  * @author Diego Krupitza
+ * @author Kurt Niemi
  */
 public class H2Dialect extends org.springframework.data.relational.core.dialect.H2Dialect implements R2dbcDialect {
 

spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/MySqlDialect.java

@@ -36,6 +36,7 @@
  *
  * @author Mark Paluch
  * @author Jens Schauder
+ * @author Kurt Niemi
  */
 public class MySqlDialect extends org.springframework.data.relational.core.dialect.MySqlDialect
 		implements R2dbcDialect {

spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/DerivedSqlIdentifier.java

@@ -29,6 +29,7 @@
  * {@link NamingStrategy}.
  *
  * @author Mark Paluch
+ * @author Kurt Niemi
  * @since 2.0
  */
 class DerivedSqlIdentifier implements SqlIdentifier {
@@ -67,7 +68,7 @@ public String toSql(IdentifierProcessing processing) {
 	@Override
 	@Deprecated(since="3.1", forRemoval = true)
 	public String getReference(IdentifierProcessing processing) {
-		return toSql(processing);
+		return this.name;
 	}
 
 	@Override

spring-data-relational/src/main/java/org/springframework/data/relational/core/mapping/NamingStrategy.java

@@ -31,6 +31,7 @@
  * @author Kazuki Shimizu
  * @author Jens Schauder
  * @author Oliver Gierke
+ * @author Kurt Niemi
  */
 public interface NamingStrategy {