Associate value with isTrue/isFalse criteria operators.

We now associate a boolean value with both operators as those operators are rendered using equals comparison in the actual SQL text.

Orginal pull request #1188

Author: mp911de

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/QueryMapper.java

@@ -494,13 +494,15 @@ private Condition createCondition(Column column, @Nullable Object mappedValue, S
 
 		if (comparator == Comparator.IS_TRUE) {
 
-			Expression bind = bindBoolean(column, parameterSource, true);
+			Expression bind = bindBoolean(column, parameterSource,
+					mappedValue instanceof Boolean ? (Boolean) mappedValue : true);
 			return column.isEqualTo(bind);
 		}
 
 		if (comparator == Comparator.IS_FALSE) {
 
-			Expression bind = bindBoolean(column, parameterSource, false);
+			Expression bind = bindBoolean(column, parameterSource,
+					mappedValue instanceof Boolean ? (Boolean) mappedValue : false);
 			return column.isEqualTo(bind);
 		}
 

spring-data-relational/src/main/java/org/springframework/data/relational/core/query/Criteria.java

@@ -849,7 +849,7 @@ public Criteria isNotNull() {
 		 */
 		@Override
 		public Criteria isTrue() {
-			return createCriteria(Comparator.IS_TRUE, null);
+			return createCriteria(Comparator.IS_TRUE, true);
 		}
 
 		/*
@@ -858,7 +858,7 @@ public Criteria isTrue() {
 		 */
 		@Override
 		public Criteria isFalse() {
-			return createCriteria(Comparator.IS_FALSE, null);
+			return createCriteria(Comparator.IS_FALSE, false);
 		}
 
 		protected Criteria createCriteria(Comparator comparator, @Nullable Object value) {

spring-data-relational/src/test/java/org/springframework/data/relational/core/query/CriteriaUnitTests.java

@@ -285,6 +285,7 @@ public void shouldBuildIsTrueCriteria() {
 
 		assertThat(criteria.getColumn()).isEqualTo(SqlIdentifier.unquoted("foo"));
 		assertThat(criteria.getComparator()).isEqualTo(CriteriaDefinition.Comparator.IS_TRUE);
+		assertThat(criteria.getValue()).isEqualTo(true);
 	}
 
 	@Test // DATAJDBC-513
@@ -294,5 +295,6 @@ public void shouldBuildIsFalseCriteria() {
 
 		assertThat(criteria.getColumn()).isEqualTo(SqlIdentifier.unquoted("foo"));
 		assertThat(criteria.getComparator()).isEqualTo(CriteriaDefinition.Comparator.IS_FALSE);
+		assertThat(criteria.getValue()).isEqualTo(false);
 	}
 }