Fix misordered 'final static' modifiers.

Per the Java Language Specification (Java 17; https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.3.1), 'static' should appear before 'final'.

This is also consistent with source code analysis tools, like Checkstyle, rules: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheck.html.

Original pull request: #2640

Author: thachlp

src/main/java/org/springframework/data/redis/connection/ReactiveRedisConnection.java

@@ -417,7 +417,7 @@ public ByteBufferResponse(I input, @Nullable ByteBuffer output) {
 	 */
 	class AbsentByteBufferResponse<I> extends ByteBufferResponse<I> {
 
-		private final static ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.wrap(new byte[0]);
+		private static final ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.wrap(new byte[0]);
 
 		public AbsentByteBufferResponse(I input) {
 			super(input, EMPTY_BYTE_BUFFER);

src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java

@@ -87,7 +87,7 @@
  */
 public class JedisConnectionFactory implements InitializingBean, DisposableBean, RedisConnectionFactory {
 
-	private final static Log log = LogFactory.getLog(JedisConnectionFactory.class);
+	private static final Log log = LogFactory.getLog(JedisConnectionFactory.class);
 	private static final ExceptionTranslationStrategy EXCEPTION_TRANSLATION = new PassThroughExceptionTranslationStrategy(
 			JedisExceptionConverter.INSTANCE);
 

src/main/java/org/springframework/data/redis/connection/lettuce/LettucePoolingConnectionProvider.java

@@ -60,7 +60,7 @@
  */
 class LettucePoolingConnectionProvider implements LettuceConnectionProvider, RedisClientProvider, DisposableBean {
 
-	private final static Log log = LogFactory.getLog(LettucePoolingConnectionProvider.class);
+	private static final Log log = LogFactory.getLog(LettucePoolingConnectionProvider.class);
 
 	private final LettuceConnectionProvider connectionProvider;
 	private final GenericObjectPoolConfig poolConfig;

src/main/java/org/springframework/data/redis/core/RedisCommand.java

@@ -222,7 +222,7 @@ public enum RedisCommand {
 	private int minArgs = -1;
 	private int maxArgs = -1;
 
-	private final static Map<String, RedisCommand> commandLookup;
+	private static final Map<String, RedisCommand> commandLookup;
 
 	static {
 		commandLookup = buildCommandLookupTable();

src/main/java/org/springframework/data/redis/core/StreamObjectMapper.java

@@ -47,8 +47,8 @@
  */
 class StreamObjectMapper {
 
-	private final static RedisCustomConversions customConversions = new RedisCustomConversions();
-	private final static ConversionService conversionService;
+	private static final RedisCustomConversions customConversions = new RedisCustomConversions();
+	private static final ConversionService conversionService;
 
 	private final HashMapper<Object, Object, Object> mapper;
 	private final @Nullable HashMapper<Object, Object, Object> objectHashMapper;

src/main/java/org/springframework/data/redis/serializer/RedisSerializerToSerializationPairAdapter.java

@@ -30,10 +30,10 @@
  */
 class RedisSerializerToSerializationPairAdapter<T> implements SerializationPair<T> {
 
-	private final static RedisSerializerToSerializationPairAdapter<?> BYTE_BUFFER = new RedisSerializerToSerializationPairAdapter<>(
+	private static final RedisSerializerToSerializationPairAdapter<?> BYTE_BUFFER = new RedisSerializerToSerializationPairAdapter<>(
 			null);
 
-	private final static RedisSerializerToSerializationPairAdapter<byte[]> BYTE_ARRAY = new RedisSerializerToSerializationPairAdapter<>(
+	private static final RedisSerializerToSerializationPairAdapter<byte[]> BYTE_ARRAY = new RedisSerializerToSerializationPairAdapter<>(
 			RedisSerializer.byteArray());
 
 	private final DefaultSerializationPair pair;

src/test/java/org/springframework/data/redis/SettingsUtils.java

@@ -34,7 +34,7 @@
  */
 public abstract class SettingsUtils {
 
-	private final static Properties DEFAULTS = new Properties();
+	private static final Properties DEFAULTS = new Properties();
 	private static final Properties SETTINGS;
 
 	static {

src/test/java/org/springframework/data/redis/cache/LegacyRedisCacheTests.java

@@ -54,7 +54,7 @@
 @MethodSource("testParams")
 public class LegacyRedisCacheTests {
 
-	private final static String CACHE_NAME = "testCache";
+	private static final String CACHE_NAME = "testCache";
 	private ObjectFactory<Object> keyFactory;
 	private ObjectFactory<Object> valueFactory;
 	private RedisConnectionFactory connectionFactory;

src/test/java/org/springframework/data/redis/test/XstreamOxmSerializerSingleton.java

@@ -25,7 +25,7 @@
  */
 public final class XstreamOxmSerializerSingleton {
 
-	private final static XstreamOxmSerializerSingleton instance = new XstreamOxmSerializerSingleton();
+	private static final XstreamOxmSerializerSingleton instance = new XstreamOxmSerializerSingleton();
 
 	private final OxmSerializer serializer;
 

src/test/java/org/springframework/data/redis/test/extension/parametrized/MethodArgumentsProvider.java

@@ -42,7 +42,7 @@
  */
 class MethodArgumentsProvider implements ArgumentsProvider, AnnotationConsumer<MethodSource> {
 
-	private final static Namespace NAMESPACE = Namespace.create(MethodArgumentsProvider.class);
+	private static final Namespace NAMESPACE = Namespace.create(MethodArgumentsProvider.class);
 	private String[] methodNames = new String[0];
 
 	@Override