Unsubscribe only once on Subscription.close().

We now unsubscribe from Redis only once when closing a Subscription object to avoid duplicate traffic and unexpected Redis responses.

Jedis does not have a mechanism to consume the additional unsubscribe response which leaves protocol frames on the InputStream leading to a corrupt state.

Closes #2355

Author: mp911de

src/main/java/org/springframework/data/redis/connection/jedis/JedisSubscription.java

@@ -38,6 +38,7 @@ class JedisSubscription extends AbstractSubscription {
 
 	@Override
 	protected void doClose() {
+
 		if (!getChannels().isEmpty()) {
 			jedisPubSub.unsubscribe();
 		}

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceSubscription.java

@@ -76,10 +76,6 @@ protected StatefulRedisPubSubConnection<byte[], byte[]> getNativeConnection() {
 	@Override
 	protected void doClose() {
 
-		if (!isAlive()) {
-			return;
-		}
-
 		List<CompletableFuture<?>> futures = new ArrayList<>();
 
 		if (!getChannels().isEmpty()) {

src/main/java/org/springframework/data/redis/connection/util/AbstractSubscription.java

@@ -99,8 +99,19 @@ protected AbstractSubscription(MessageListener listener, @Nullable byte[][] chan
 
 	@Override
 	public void close() {
-		doClose();
-		alive.set(false);
+
+		if (alive.compareAndSet(true, false)) {
+
+			doClose();
+
+			synchronized (channels) {
+				channels.clear();
+			}
+
+			synchronized (patterns) {
+				patterns.clear();
+			}
+		}
 	}
 
 	/**

src/test/java/org/springframework/data/redis/connection/jedis/JedisSubscriptionUnitTests.java

@@ -35,6 +35,7 @@
  * Unit test of {@link JedisSubscription}
  *
  * @author Jennifer Hickey
+ * @author Mark Paluch
  */
 @ExtendWith(MockitoExtension.class)
 class JedisSubscriptionUnitTests {
@@ -305,4 +306,15 @@ void testDoCloseSubscribedPatterns() {
 		verify(jedisPubSub, times(1)).punsubscribe();
 	}
 
+	@Test // GH-2355
+	void closeTwiceShouldUnsubscribeOnce() {
+
+		subscription.subscribe(new byte[][] { "a".getBytes() });
+
+		subscription.close();
+		subscription.close();
+
+		verify(jedisPubSub, times(1)).unsubscribe();
+	}
+
 }