Skip to content

Commit cafa3c7

Browse files
committed
Align with KeyValue KeySpaceResolver changes.
We now use the KeyValue KeySpaceResolver to primarily detect the keyspace to be used instead of a fallback. See #2457 See #2452
1 parent befafa8 commit cafa3c7

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/main/java/org/springframework/data/redis/core/mapping/BasicRedisPersistentEntity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ public class BasicRedisPersistentEntity<T> extends BasicKeyValuePersistentEntity
4141
* Creates new {@link BasicRedisPersistentEntity}.
4242
*
4343
* @param information must not be {@literal null}.
44-
* @param fallbackKeySpaceResolver can be {@literal null}.
44+
* @param keySpaceResolver can be {@literal null}.
4545
* @param timeToLiveAccessor can be {@literal null}.
4646
*/
47-
public BasicRedisPersistentEntity(TypeInformation<T> information, @Nullable KeySpaceResolver fallbackKeySpaceResolver,
47+
public BasicRedisPersistentEntity(TypeInformation<T> information, @Nullable KeySpaceResolver keySpaceResolver,
4848
TimeToLiveAccessor timeToLiveAccessor) {
49-
super(information, fallbackKeySpaceResolver);
49+
super(information, keySpaceResolver);
5050

5151
Assert.notNull(timeToLiveAccessor, "TimeToLiveAccessor must not be null");
5252
this.timeToLiveAccessor = timeToLiveAccessor;

src/main/java/org/springframework/data/redis/core/mapping/RedisMappingContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public String resolveKeySpace(Class<?> type) {
133133
}
134134
}
135135

136-
return ClassNameKeySpaceResolver.INSTANCE.resolveKeySpace(type);
136+
return null;
137137
}
138138
}
139139

src/test/java/org/springframework/data/redis/core/mapping/ConfigAwareKeySpaceResolverUnitTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,18 @@
1919

2020
import org.junit.jupiter.api.BeforeEach;
2121
import org.junit.jupiter.api.Test;
22-
2322
import org.springframework.data.redis.core.convert.KeyspaceConfiguration;
2423
import org.springframework.data.redis.core.convert.KeyspaceConfiguration.KeyspaceSettings;
2524
import org.springframework.data.redis.core.mapping.RedisMappingContext.ConfigAwareKeySpaceResolver;
2625

2726
/**
27+
* Unit tests for {@link ConfigAwareKeySpaceResolver}.
28+
*
2829
* @author Christoph Strobl
30+
* @author Mark Paluch
2931
*/
3032
class ConfigAwareKeySpaceResolverUnitTests {
3133

32-
static final String CUSTOM_KEYSPACE = "car'a'carn";
3334
private KeyspaceConfiguration config = new KeyspaceConfiguration();
3435
private ConfigAwareKeySpaceResolver resolver;
3536

@@ -43,10 +44,9 @@ void resolveShouldThrowExceptionWhenTypeIsNull() {
4344
assertThatIllegalArgumentException().isThrownBy(() -> resolver.resolveKeySpace(null));
4445
}
4546

46-
@Test // DATAREDIS-425
47-
void resolveShouldUseClassNameAsDefaultKeyspace() {
48-
assertThat(resolver.resolveKeySpace(TypeWithoutAnySettings.class))
49-
.isEqualTo(TypeWithoutAnySettings.class.getName());
47+
@Test // DATAREDIS-425, GH-2457
48+
void resolveShouldReturnNullAsDefaultKeyspace() {
49+
assertThat(resolver.resolveKeySpace(TypeWithoutAnySettings.class)).isNull();
5050
}
5151

5252
@Test // DATAREDIS-425

0 commit comments

Comments
 (0)