Skip to content

Commit c4c823d

Browse files
committed
Remove Jasync from tests.
Jasync does not support MySQL's 8.0 caching_sha2_password and there are no plans to support it. See #594.
1 parent 2857580 commit c4c823d

File tree

6 files changed

+0
-257
lines changed

6 files changed

+0
-257
lines changed

pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
<degraph-check.version>0.1.4</degraph-check.version>
3131
<postgresql.version>42.2.5</postgresql.version>
3232
<mysql.version>8.0.21</mysql.version>
33-
<jasync.version>1.0.14</jasync.version>
3433
<r2dbc-spi-test.version>0.8.0.RELEASE</r2dbc-spi-test.version>
3534
<mssql-jdbc.version>7.1.2.jre8-preview</mssql-jdbc.version>
3635
<mariadb-jdbc.version>2.5.4</mariadb-jdbc.version>
@@ -242,13 +241,6 @@
242241
<scope>test</scope>
243242
</dependency>
244243

245-
<dependency>
246-
<groupId>com.github.jasync-sql</groupId>
247-
<artifactId>jasync-r2dbc-mysql</artifactId>
248-
<version>${jasync.version}</version>
249-
<scope>test</scope>
250-
</dependency>
251-
252244
<dependency>
253245
<groupId>dev.miku</groupId>
254246
<artifactId>r2dbc-mysql</artifactId>

src/test/java/org/springframework/data/r2dbc/core/JasyncMySqlDatabaseClientIntegrationTests.java

Lines changed: 0 additions & 58 deletions
This file was deleted.

src/test/java/org/springframework/data/r2dbc/core/JasyncMySqlTransactionalDatabaseClientIntegrationTests.java

Lines changed: 0 additions & 79 deletions
This file was deleted.

src/test/java/org/springframework/data/r2dbc/dialect/DialectResolverUnitTests.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.springframework.data.r2dbc.dialect;
22

33
import static org.assertj.core.api.Assertions.*;
4-
import static org.mockito.Mockito.*;
54

65
import dev.miku.r2dbc.mysql.MySqlConnectionConfiguration;
76
import dev.miku.r2dbc.mysql.MySqlConnectionFactory;
@@ -26,9 +25,6 @@
2625
import org.springframework.data.relational.core.sql.LockOptions;
2726
import org.springframework.data.relational.core.sql.render.SelectRenderContext;
2827

29-
import com.github.jasync.r2dbc.mysql.JasyncConnectionFactory;
30-
import com.github.jasync.sql.db.mysql.pool.MySQLConnectionFactory;
31-
3228
/**
3329
* Unit tests for {@link DialectResolver}.
3430
*
@@ -44,14 +40,12 @@ void shouldResolveDatabaseType() {
4440
MssqlConnectionFactory mssql = new MssqlConnectionFactory(MssqlConnectionConfiguration.builder().host("localhost")
4541
.database("foo").username("bar").password("password").build());
4642
H2ConnectionFactory h2 = new H2ConnectionFactory(H2ConnectionConfiguration.builder().inMemory("mem").build());
47-
JasyncConnectionFactory jasyncMysql = new JasyncConnectionFactory(mock(MySQLConnectionFactory.class));
4843
MySqlConnectionFactory mysql = MySqlConnectionFactory
4944
.from(MySqlConnectionConfiguration.builder().host("localhost").username("mysql").build());
5045

5146
assertThat(DialectResolver.getDialect(postgres)).isEqualTo(PostgresDialect.INSTANCE);
5247
assertThat(DialectResolver.getDialect(mssql)).isEqualTo(SqlServerDialect.INSTANCE);
5348
assertThat(DialectResolver.getDialect(h2)).isEqualTo(H2Dialect.INSTANCE);
54-
assertThat(DialectResolver.getDialect(jasyncMysql)).isEqualTo(MySqlDialect.INSTANCE);
5549
assertThat(DialectResolver.getDialect(mysql)).isEqualTo(MySqlDialect.INSTANCE);
5650
}
5751

src/test/java/org/springframework/data/r2dbc/repository/JasyncMySqlR2dbcRepositoryIntegrationTests.java

Lines changed: 0 additions & 97 deletions
This file was deleted.

src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,6 @@ private static ExternalDatabase testContainer() {
125125
return testContainerDatabase;
126126
}
127127

128-
/**
129-
* Creates a new Jasync MySQL {@link ConnectionFactory} configured from the {@link ExternalDatabase}.
130-
*/
131-
public static ConnectionFactory createJasyncConnectionFactory(ExternalDatabase database) {
132-
133-
ConnectionFactoryOptions options = ConnectionUtils.createOptions("mysql", database);
134-
return new MysqlConnectionFactoryProvider().create(options);
135-
}
136-
137128
/**
138129
* Creates a new R2DBC MySQL {@link ConnectionFactory} configured from the {@link ExternalDatabase}.
139130
*/

0 commit comments

Comments
 (0)