GH-1911 - Polishing.

This changes the return types of the `CypherdslConditionExecutor` into `Collection` and aligns it with the `CypherdslStatementExecutor` and in the long run with the goal Spring Data Commons has for the `QuerydslPredicateExecutor`.  It makes more sense for this new API to align with the desired state instead of something we consider suboptimal.

Author: michael-simons

src/main/java/org/springframework/data/neo4j/repository/query/CypherdslConditionExecutorImpl.java

@@ -17,6 +17,7 @@
 
 import static org.neo4j.cypherdsl.core.Cypher.asterisk;
 
+import java.util.Collection;
 import java.util.List;
 import java.util.Optional;
 import java.util.function.LongSupplier;
@@ -69,7 +70,7 @@ public Optional<T> findOne(Condition condition) {
 	}
 
 	@Override
-	public Iterable<T> findAll(Condition condition) {
+	public Collection<T> findAll(Condition condition) {
 
 		return this.neo4jOperations.toExecutableQuery(
 				this.metaData.getType(),
@@ -78,7 +79,7 @@ public Iterable<T> findAll(Condition condition) {
 	}
 
 	@Override
-	public Iterable<T> findAll(Condition condition, Sort sort) {
+	public Collection<T> findAll(Condition condition, Sort sort) {
 
 		return this.neo4jOperations.toExecutableQuery(
 				metaData.getType(),
@@ -89,7 +90,7 @@ public Iterable<T> findAll(Condition condition, Sort sort) {
 	}
 
 	@Override
-	public Iterable<T> findAll(Condition condition, SortItem... sortItems) {
+	public Collection<T> findAll(Condition condition, SortItem... sortItems) {
 
 		return this.neo4jOperations.toExecutableQuery(
 				this.metaData.getType(),
@@ -100,7 +101,7 @@ public Iterable<T> findAll(Condition condition, SortItem... sortItems) {
 	}
 
 	@Override
-	public Iterable<T> findAll(SortItem... sortItems) {
+	public Collection<T> findAll(SortItem... sortItems) {
 
 		return this.neo4jOperations.toExecutableQuery(
 				this.metaData.getType(),

src/main/java/org/springframework/data/neo4j/repository/support/CypherdslConditionExecutor.java

@@ -15,6 +15,7 @@
  */
 package org.springframework.data.neo4j.repository.support;
 
+import java.util.Collection;
 import java.util.Optional;
 
 import org.apiguardian.api.API;
@@ -37,13 +38,13 @@ public interface CypherdslConditionExecutor<T> {
 
 	Optional<T> findOne(Condition condition);
 
-	Iterable<T> findAll(Condition condition);
+	Collection<T> findAll(Condition condition);
 
-	Iterable<T> findAll(Condition condition, Sort sort);
+	Collection<T> findAll(Condition condition, Sort sort);
 
-	Iterable<T> findAll(Condition condition, SortItem... sortItems);
+	Collection<T> findAll(Condition condition, SortItem... sortItems);
 
-	Iterable<T> findAll(SortItem... sortItems);
+	Collection<T> findAll(SortItem... sortItems);
 
 	Page<T> findAll(Condition condition, Pageable pageable);