Initialize lists with size where possible.

christophstrobl · mp911de · commit 7b30423356f5 · 2022-09-16T14:45:17.000+02:00
Closes #3941 Original pull request: #3974.
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/CountQuery.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/CountQuery.java
@@ -176,16 +176,20 @@ private static Document createGeoWithin(String key, Document source, @Nullable O
 		Document $geoWithinMin = new Document("$geoWithin",
 				new Document(spheric ? "$centerSphere" : "$center", $centerMin));
 
-		List<Document> criteria = new ArrayList<>();
+		List<Document> criteria;
 
 		if ($and != null) {
 			if ($and instanceof Collection) {
-				criteria.addAll((Collection) $and);
+				Collection andElements = (Collection) $and;
+				criteria = new ArrayList<>(andElements.size() + 2);
+				criteria.addAll(andElements);
 			} else {
 				throw new IllegalArgumentException(
 						"Cannot rewrite query as it contains an '$and' element that is not a Collection!: Offending element: "
 								+ $and);
 			}
+		} else {
+			criteria = new ArrayList<>(2);
 		}
 
 		criteria.add(new Document("$nor", Collections.singletonList(new Document(key, $geoWithinMin))));
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultIndexOperations.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultIndexOperations.java
@@ -188,7 +188,8 @@ public List<IndexInfo> doInCollection(MongoCollection<Document> collection)
 
 			private List<IndexInfo> getIndexData(MongoCursor<Document> cursor) {
 
-				List<IndexInfo> indexInfoList = new ArrayList<>();
+				int available = cursor.available();
+				List<IndexInfo> indexInfoList = available > 0 ? new ArrayList<>(available) : new ArrayList<>();
 
 				while (cursor.hasNext()) {
 
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java
@@ -1022,7 +1022,7 @@ public <T> GeoResults<T> geoNear(NearQuery near, Class<?> domainType, String col
 		DocumentCallback<GeoResult<T>> callback = new GeoNearResultDocumentCallback<>(distanceField,
 				new ProjectingReadCallback<>(mongoConverter, projection, collection), near.getMetric());
 
-		List<GeoResult<T>> result = new ArrayList<>();
+		List<GeoResult<T>> result = new ArrayList<>(results.getMappedResults().size());
 
 		BigDecimal aggregate = BigDecimal.ZERO;
 		for (Document element : results) {
@@ -1411,7 +1411,7 @@ protected <T> Collection<T> doInsertBatch(String collectionName, Collection<? ex
 
 		Assert.notNull(writer, "MongoWriter must not be null!");
 
-		List<Document> documentList = new ArrayList<>();
+		List<Document> documentList = new ArrayList<>(batchToSave.size());
 		List<T> initializedBatchToSave = new ArrayList<>(batchToSave.size());
 		for (T uninitialized : batchToSave) {
 
@@ -2965,7 +2965,8 @@ private <T> List<T> executeFindMultiInternal(CollectionCallback<FindIterable<Doc
 					.initiateFind(getAndPrepareCollection(doGetDatabase(), collectionName), collectionCallback::doInCollection)
 					.iterator()) {
 
-				List<T> result = new ArrayList<>();
+				int available = cursor.available();
+				List<T> result = available > 0 ? new ArrayList<>(available) : new ArrayList<>();
 
 				while (cursor.hasNext()) {
 					Document object = cursor.next();
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveMongoTemplate.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveMongoTemplate.java
@@ -1712,7 +1712,7 @@ protected Flux<ObjectId> insertDocumentList(String collectionName, List<Document
 			LOGGER.debug(String.format("Inserting list of Documents containing %d items", dbDocList.size()));
 		}
 
-		List<Document> documents = new ArrayList<>();
+		List<Document> documents = new ArrayList<>(dbDocList.size());
 
 		return execute(collectionName, collection -> {
 
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/ConditionalOperators.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/ConditionalOperators.java
@@ -675,10 +675,7 @@ private Object resolveCriteria(AggregationOperationContext context, Object value
 			if (value instanceof CriteriaDefinition) {
 
 				Document mappedObject = context.getMappedObject(((CriteriaDefinition) value).getCriteriaObject());
-				List<Object> clauses = new ArrayList<Object>();
-
-				clauses.addAll(getClauses(context, mappedObject));
-
+				List<Object> clauses = getClauses(context, mappedObject);
 				return clauses.size() == 1 ? clauses.get(0) : clauses;
 			}
 
@@ -705,7 +702,9 @@ private List<Object> getClauses(AggregationOperationContext context, String key,
 
 			if (predicate instanceof List) {
 
-				List<Object> args = new ArrayList<Object>();
+				List<?> predicates = (List<?>) predicate;
+				List<Object> args = new ArrayList<Object>(predicates.size());
+
 				for (Object clause : (List<?>) predicate) {
 					if (clause instanceof Document) {
 						args.addAll(getClauses(context, (Document) clause));
@@ -723,14 +722,14 @@ private List<Object> getClauses(AggregationOperationContext context, String key,
 						continue;
 					}
 
-					List<Object> args = new ArrayList<Object>();
+					List<Object> args = new ArrayList<Object>(2);
 					args.add("$" + key);
 					args.add(nested.get(s));
 					clauses.add(new Document(s, args));
 				}
 			} else if (!isKeyword(key)) {
 
-				List<Object> args = new ArrayList<Object>();
+				List<Object> args = new ArrayList<Object>(2);
 				args.add("$" + key);
 				args.add(predicate);
 				clauses.add(new Document("$eq", args));
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/ExposedFields.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/ExposedFields.java
@@ -110,7 +110,7 @@ public static ExposedFields nonSynthetic(Fields fields) {
 	private static ExposedFields createFields(Fields fields, boolean synthetic) {
 
 		Assert.notNull(fields, "Fields must not be null!");
-		List<ExposedField> result = new ArrayList<ExposedField>();
+		List<ExposedField> result = new ArrayList<ExposedField>(fields.size());
 
 		for (Field field : fields) {
 			result.add(new ExposedField(field, synthetic));
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Fields.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Fields.java
@@ -167,6 +167,10 @@ public Fields and(Fields fields) {
 		return result;
 	}
 
+	public int size() {
+		return fields.size();
+	}
+
 	@Nullable
 	public Field getField(String name) {
 
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/GeoNearOperation.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/GeoNearOperation.java
@@ -126,7 +126,7 @@ public List<Document> toPipelineStages(AggregationOperationContext context) {
 		Document command = toDocument(context);
 		Number limit = (Number) command.get("$geoNear", Document.class).remove("num");
 
-		List<Document> stages = new ArrayList<>();
+		List<Document> stages = new ArrayList<>(3);
 		stages.add(command);
 
 		if (nearQuery.getSkip() != null && nearQuery.getSkip() > 0) {
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/DefaultDbRefResolver.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/DefaultDbRefResolver.java
@@ -138,7 +138,7 @@ public List<Document> bulkFetch(List<DBRef> refs) {
 
 		List<Document> result = mongoCollection //
 				.find(new Document(BasicMongoPersistentProperty.ID_FIELD_NAME, new Document("$in", ids))) //
-				.into(new ArrayList<>());
+				.into(new ArrayList<>(ids.size()));
 
 		return ids.stream() //
 				.flatMap(id -> documentWithId(id, result)) //
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/GeoConverters.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/GeoConverters.java
@@ -462,7 +462,7 @@ public Document convert(GeoCommand source) {
 				return null;
 			}
 
-			List<Object> argument = new ArrayList<>();
+			List<Object> argument = new ArrayList<>(2);
 
 			Shape shape = source.getShape();
 
@@ -482,7 +482,9 @@ public Document convert(GeoCommand source) {
 
 			} else if (shape instanceof Polygon) {
 
-				for (Point point : ((Polygon) shape).getPoints()) {
+				List<Point> points = ((Polygon) shape).getPoints();
+				argument = new ArrayList(points.size());
+				for (Point point : points) {
 					argument.add(toList(point));
 				}
 
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java
@@ -1018,14 +1018,14 @@ protected List<Object> createCollection(Collection<?> collection, MongoPersisten
 				}).collect(Collectors.toList());
 
 				return writeCollectionInternal(targetCollection, ClassTypeInformation.from(DocumentPointer.class),
-						new ArrayList<>());
+						new ArrayList<>(targetCollection.size()));
 			}
 
 			if (property.hasExplicitWriteTarget()) {
-				return writeCollectionInternal(collection, new FieldTypeInformation<>(property), new ArrayList<>());
+				return writeCollectionInternal(collection, new FieldTypeInformation<>(property), new ArrayList<>(collection.size()));
 			}
 
-			return writeCollectionInternal(collection, property.getTypeInformation(), new ArrayList<>());
+			return writeCollectionInternal(collection, property.getTypeInformation(), new ArrayList<>(collection.size()));
 		}
 
 		List<Object> dbList = new ArrayList<>(collection.size());
@@ -1110,7 +1110,9 @@ private List<Object> writeCollectionInternal(Collection<?> source, @Nullable Typ
 				collection.add(getPotentiallyConvertedSimpleWrite(element,
 						componentType != null ? componentType.getType() : Object.class));
 			} else if (element instanceof Collection || elementType.isArray()) {
-				collection.add(writeCollectionInternal(BsonUtils.asCollection(element), componentType, new ArrayList<>()));
+
+				Collection<?> objects = BsonUtils.asCollection(element);
+				collection.add(writeCollectionInternal(objects, componentType, new ArrayList<>(objects.size())));
 			} else {
 				Document document = new Document();
 				writeInternal(element, document, componentType);
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java
@@ -376,7 +376,7 @@ protected Document getMappedKeyword(Keyword keyword, @Nullable MongoPersistentEn
 		if (keyword.isOrOrNor() || (keyword.hasIterableValue() && !keyword.isGeometry())) {
 
 			Iterable<?> conditions = keyword.getValue();
-			List<Object> newConditions = new ArrayList<>();
+			List<Object> newConditions = conditions instanceof Collection ? new ArrayList<>(((Collection<?>) conditions).size()) : new ArrayList<>();
 
 			for (Object condition : conditions) {
 				newConditions.add(isDocument(condition) ? getMappedObject((Document) condition, entity)
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java
@@ -337,7 +337,7 @@ public Criteria nin(Collection<?> values) {
 	 * @see <a href="https://docs.mongodb.com/manual/reference/operator/query/mod/">MongoDB Query operator: $mod</a>
 	 */
 	public Criteria mod(Number value, Number remainder) {
-		List<Object> l = new ArrayList<Object>();
+		List<Object> l = new ArrayList<Object>(2);
 		l.add(value);
 		l.add(remainder);
 		criteria.put("$mod", l);
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ConvertingParameterAccessor.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ConvertingParameterAccessor.java
@@ -229,8 +229,10 @@ public Object nextConverted(MongoPersistentProperty property) {
 			if (property.isAssociation()) {
 				if (next.getClass().isArray() || next instanceof Iterable) {
 
-					List<DBRef> dbRefs = new ArrayList<DBRef>();
-					for (Object element : asCollection(next)) {
+					Collection<?> values = asCollection(next);
+
+					List<DBRef> dbRefs = new ArrayList<DBRef>(values.size());
+					for (Object element : values) {
 						dbRefs.add(writer.toDBRef(element, property));
 					}
 
@@ -264,11 +266,14 @@ private static Collection<?> asCollection(@Nullable Object source) {
 
 		if (source instanceof Iterable) {
 
-			List<Object> result = new ArrayList<Object>();
+			if(source instanceof Collection) {
+				return new ArrayList<>((Collection<?>) source);
+			}
+
+			List<Object> result = new ArrayList<>();
 			for (Object element : (Iterable<?>) source) {
 				result.add(element);
 			}
-
 			return result;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1712,7 +1712,7 @@ protected Flux<ObjectId> insertDocumentList(String collectionName, List<Document`
`1712`	`1712`	`LOGGER.debug(String.format("Inserting list of Documents containing %d items", dbDocList.size()));`
`1713`	`1713`	`}`
`1714`	`1714`
`1715`		`- List<Document> documents = new ArrayList<>();`
	`1715`	`+ List<Document> documents = new ArrayList<>(dbDocList.size());`
`1716`	`1716`
`1717`	`1717`	`return execute(collectionName, collection -> {`
`1718`	`1718`
Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,10 @@ public Fields and(Fields fields) {`
`167`	`167`	`return result;`
`168`	`168`	`}`
`169`	`169`
	`170`	`+ public int size() {`
	`171`	`+ return fields.size();`
	`172`	`+ }`
	`173`	`+`
`170`	`174`	`@Nullable`
`171`	`175`	`public Field getField(String name) {`
`172`	`176`
Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ public Document convert(GeoCommand source) {`
`462`	`462`	`return null;`
`463`	`463`	`}`
`464`	`464`
`465`		`- List<Object> argument = new ArrayList<>();`
	`465`	`+ List<Object> argument = new ArrayList<>(2);`
`466`	`466`
`467`	`467`	`Shape shape = source.getShape();`
`468`	`468`
`@@ -482,7 +482,9 @@ public Document convert(GeoCommand source) {`
`482`	`482`
`483`	`483`	`} else if (shape instanceof Polygon) {`
`484`	`484`
`485`		`- for (Point point : ((Polygon) shape).getPoints()) {`
	`485`	`+ List<Point> points = ((Polygon) shape).getPoints();`
	`486`	`+ argument = new ArrayList(points.size());`
	`487`	`+ for (Point point : points) {`
`486`	`488`	`argument.add(toList(point));`
`487`	`489`	`}`
`488`	`490`