Validate aggregation query method on query method creation.

This commit makes sure to fail early if an annotated string based annotation does not contain a syntactically valid pipeline.

Original pull request: #4547
Closes #4546

Author: christophstrobl

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryMethod.java

@@ -39,6 +39,7 @@
 import org.springframework.data.mongodb.repository.ReadPreference;
 import org.springframework.data.mongodb.repository.Tailable;
 import org.springframework.data.mongodb.repository.Update;
+import org.springframework.data.mongodb.util.BsonUtils;
 import org.springframework.data.projection.ProjectionFactory;
 import org.springframework.data.repository.core.RepositoryMetadata;
 import org.springframework.data.repository.query.QueryMethod;
@@ -504,6 +505,16 @@ public void verify() {
 				}
 			}
 		}
+		if (hasAnnotatedAggregation()) {
+			for (String stage : getAnnotatedAggregation()) {
+				if (BsonUtils.isJsonArray(stage)) {
+					throw new IllegalStateException("""
+							Invalid aggregation pipeline. Please split Aggregation.pipeline from "[{...}, {...}]" to "{...}", "{...}".
+							Offending Method: %s.%s
+							""".formatted(method.getDeclaringClass().getSimpleName(), method.getName()));
+				}
+			}
+		}
 	}
 
 	private boolean isNumericOrVoidReturnValue() {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/MongoQueryMethodUnitTests.java

@@ -358,6 +358,15 @@ void detectsReadPreferenceForAggregation() throws Exception {
 		assertThat(method.getAnnotatedReadPreference()).isEqualTo("secondaryPreferred");
 	}
 
+	@Test // GH-4546
+	void errorsOnInvalidAggregation() throws Exception {
+
+		assertThatExceptionOfType(IllegalStateException.class) //
+				.isThrownBy(() -> queryMethod(InvalidAggregationMethodRepo.class, "findByAggregation").verify()) //
+				.withMessageContaining("Invalid aggregation") //
+				.withMessageContaining("findByAggregation");
+	}
+
 	private MongoQueryMethod queryMethod(Class<?> repository, String name, Class<?>... parameters) throws Exception {
 
 		Method method = repository.getMethod(name, parameters);
@@ -465,6 +474,12 @@ interface InvalidUpdateMethodRepo extends Repository<Person, Long> {
 		Person findAndIncrementVisitsByFirstname(String firstname);
 	}
 
+	interface InvalidAggregationMethodRepo extends Repository<Person, Long> {
+
+		@Aggregation("[{'$group': { _id: '$templateId', maxVersion : { $max : '$version'} } }]")
+		List<User> findByAggregation();
+	}
+
 	interface Customer {
 
 	}