Sorting and limits are ignored

[cdprete]

Hello.

In one of my applications using Spring Boot 3.5.7 (and grabbing its dependencies from the BoM), I tried to define an LdapRepository as follows:

@Validated
@Entry(base = "tkfdomtyp=109", objectClasses = "tkfdomain.gzip")
public final class AdjustmentFactorLdapEntry {
    @Id
    @NotNull
    private Name domain;

    @NotBlank
    @Attribute(name = "domain-name")
    private String domainName;

    @NotEmpty
    @Attribute(name = "domain;binary", type = BINARY)
    private byte[] data;

    @Attribute(name = "svn-revision")
    private int revision;

    public Name getDomain() {
        return domain;
    }

    public void setDomain(Name domain) {
        this.domain = domain;
    }

    public String getDomainName() {
        return domainName;
    }

    public void setDomainName(String domainName) {
        this.domainName = domainName;
    }

    public byte[] getData() {
        return data;
    }

    public void setData(byte[] data) {
        this.data = data;
    }

    public int getRevision() {
        return revision;
    }

    public void setRevision(int revision) {
        this.revision = revision;
    }

    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (!(o instanceof AdjustmentFactorLdapEntry gmsEntity)) return false;
        return Objects.equals(domain, gmsEntity.domain);
    }

    @Override
    public int hashCode() {
        return Objects.hashCode(domain);
    }
}

public interface AdjustmentFactorLdapRepository extends LdapRepository<AdjustmentFactorLdapEntry> {
    Optional<AdjustmentFactorLdapEntry> findFirstByDomainNameOrderByRevisionDesc(String domainName);
}

with the assumption that only the first newest entry would be returned, but actually I get:

• all the results back instead of only one, making therefore the code fail
• the sorting gets completely ignored

Am I missing something or is indeed such a feature not supported?
Debugging org.springframework.data.ldap.repository.query.LdapQueryExecution.FindOneExecution which gets called, I can see no limits no sorts attribute being passed.

[mp911de]

Thanks for reaching out. Applying the limit is indeed a bug and I filed a separate ticket #586 to fix this.

Sorting is a bit more involved and I'm not quite sure we're able to provide such functionality because of the LdapContext design. Functionality such as pagination or sorting requires associating the LdapContext object (which is typically a shared connection to the LDAP server) with SortControl, meaning a call that requires sorting would modify the LdapContext object resulting in all sorts of potential races. Spring LDAP's ContextSource can return either new objects that are valid just for one call, a singleton or pooled instances.

I think to make sorting work, LdapTemplate would have to either provide dedicated functionality to accept sort properties and create a new LdapContext via LdapContext newInstance(Control[] requestControls) or expose in some way a customizer to LdapContext.

[cdprete]

Hello @mp911de.

I think it's even more complex than that.
I tried to make it work without the goodies of Spring Data LDAP and I had the following blockers/no-go:

• If some request controls are applied, the query crashes if the context is a pooling one
• sorting needs to keep into account the data-type of the fields