Add support for using custom BeanNameGenerator.

Closes: #3440

Author: christophstrobl

spring-data-envers/src/main/java/org/springframework/data/envers/repository/config/EnableEnversRepositories.java

@@ -24,6 +24,7 @@
 import java.lang.annotation.Target;
 
 import org.springframework.beans.factory.FactoryBean;
+import org.springframework.beans.factory.support.BeanNameGenerator;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Lazy;
 import org.springframework.core.annotation.AliasFor;
@@ -136,6 +137,15 @@
 	@AliasFor(annotation = EnableJpaRepositories.class)
 	Class<?> repositoryBaseClass() default DefaultRepositoryBaseClass.class;
 
+	/**
+	 * Configure a specific {@link BeanNameGenerator} to be used when creating the repositoy beans.
+	 * @return the {@link BeanNameGenerator} to be used or the base {@link BeanNameGenerator} interface to indicate context default.
+	 * @since 3.4
+	 * @see EnableJpaRepositories#nameGenerator()
+	 */
+	@AliasFor(annotation = EnableJpaRepositories.class)
+	Class<? extends BeanNameGenerator> nameGenerator() default BeanNameGenerator.class;
+
 	// JPA specific configuration
 
 	/**

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/config/EnableJpaRepositories.java

@@ -24,6 +24,7 @@
 import java.lang.annotation.Target;
 
 import org.springframework.beans.factory.FactoryBean;
+import org.springframework.beans.factory.support.BeanNameGenerator;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Import;
 import org.springframework.context.annotation.Lazy;
@@ -119,6 +120,13 @@
 	 */
 	Class<?> repositoryBaseClass() default DefaultRepositoryBaseClass.class;
 
+	/**
+	 * Configure a specific {@link BeanNameGenerator} to be used when creating the repository beans.
+	 * @return the {@link BeanNameGenerator} to be used or the base {@link BeanNameGenerator} interface to indicate context default.
+	 * @since 3.4
+	 */
+	Class<? extends BeanNameGenerator> nameGenerator() default BeanNameGenerator.class;
+
 	// JPA specific configuration
 
 	/**

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/config/JpaRepositoriesRegistrarUnitTests.java

@@ -18,11 +18,16 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.util.Arrays;
+import java.util.stream.Stream;
 
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.support.BeanDefinitionRegistry;
 import org.springframework.beans.factory.support.DefaultListableBeanFactory;
+import org.springframework.context.annotation.AnnotationBeanNameGenerator;
 import org.springframework.core.env.StandardEnvironment;
 import org.springframework.core.io.DefaultResourceLoader;
 import org.springframework.core.type.AnnotationMetadata;
@@ -34,33 +39,54 @@
  * @author Oliver Gierke
  * @author Jens Schauder
  * @author Erik Pellizzon
+ * @author Christoph Strobl
  */
 class JpaRepositoriesRegistrarUnitTests {
 
 	private BeanDefinitionRegistry registry;
-	private AnnotationMetadata metadata;
 
 	@BeforeEach
 	void setUp() {
-
-		metadata = AnnotationMetadata.introspect(Config.class);
 		registry = new DefaultListableBeanFactory();
 	}
 
-	@Test
-	void configuresRepositoriesCorrectly() {
+
+	@ParameterizedTest // GH-499, GH-3440
+	@MethodSource(value = { "args" })
+	void configuresRepositoriesCorrectly(AnnotationMetadata metadata, String[] beanNames) {
 
 		JpaRepositoriesRegistrar registrar = new JpaRepositoriesRegistrar();
 		registrar.setResourceLoader(new DefaultResourceLoader());
 		registrar.setEnvironment(new StandardEnvironment());
 		registrar.registerBeanDefinitions(metadata, registry);
 
 		Iterable<String> names = Arrays.asList(registry.getBeanDefinitionNames());
-		assertThat(names).contains("userRepository", "auditableUserRepository", "roleRepository");
+		assertThat(names).contains(beanNames);
+	}
+
+	static Stream<Arguments> args() {
+		return Stream.of(
+				Arguments.of(AnnotationMetadata.introspect(Config.class),
+						new String[] { "userRepository", "auditableUserRepository", "roleRepository" }),
+				Arguments.of(AnnotationMetadata.introspect(ConfigWithBeanNameGenerator.class),
+						new String[] { "userREPO", "auditableUserREPO", "roleREPO" }));
 	}
 
 	@EnableJpaRepositories(basePackageClasses = UserRepository.class)
 	private class Config {
 
 	}
+
+	@EnableJpaRepositories(basePackageClasses = UserRepository.class, nameGenerator = MyBeanNameGenerator.class)
+	private class ConfigWithBeanNameGenerator {
+
+	}
+
+	static class MyBeanNameGenerator extends AnnotationBeanNameGenerator {
+
+		@Override
+		public String generateBeanName(BeanDefinition definition, BeanDefinitionRegistry registry) {
+			return super.generateBeanName(definition, registry).replaceAll("Repository", "REPO");
+		}
+	}
 }