Skip to content

Commit fd7f5c5

Browse files
committed
Rename TestImage.OPENTELEMETRY to OTEL_COLLECTOR
Closes gh-47956
1 parent 7e58970 commit fd7f5c5

File tree

7 files changed

+11
-10
lines changed

7 files changed

+11
-10
lines changed

module/spring-boot-micrometer-metrics/src/dockerTest/java/org/springframework/boot/micrometer/metrics/docker/compose/otlp/OpenTelemetryMetricsDockerComposeConnectionDetailsFactoryIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424

2525
/**
2626
* Integration tests for {@link OpenTelemetryMetricsDockerComposeConnectionDetailsFactory}
27-
* using {@link TestImage#OPENTELEMETRY}.
27+
* using {@link TestImage#OTEL_COLLECTOR}.
2828
*
2929
* @author Eddú Meléndez
3030
*/
3131
class OpenTelemetryMetricsDockerComposeConnectionDetailsFactoryIntegrationTests {
3232

33-
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OPENTELEMETRY)
33+
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OTEL_COLLECTOR)
3434
void runCreatesConnectionDetails(OtlpMetricsConnectionDetails connectionDetails) {
3535
assertThat(connectionDetails.getUrl()).startsWith("http://").endsWith("/v1/metrics");
3636
}

module/spring-boot-micrometer-metrics/src/dockerTest/java/org/springframework/boot/micrometer/metrics/testcontainers/otlp/OpenTelemetryMetricsContainerConnectionDetailsFactoryIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class OpenTelemetryMetricsContainerConnectionDetailsFactoryIntegrationTests {
6767

6868
@Container
6969
@ServiceConnection
70-
static final GenericContainer<?> container = TestImage.OPENTELEMETRY.genericContainer()
70+
static final GenericContainer<?> container = TestImage.OTEL_COLLECTOR.genericContainer()
7171
.withCommand("--config=/etc/" + CONFIG_FILE_NAME)
7272
.withCopyToContainer(MountableFile.forClasspathResource(CONFIG_FILE_NAME), "/etc/" + CONFIG_FILE_NAME)
7373
.withExposedPorts(4318, 9090);

module/spring-boot-micrometer-tracing-opentelemetry/src/dockerTest/java/org/springframework/boot/micrometer/tracing/opentelemetry/docker/compose/otlp/OpenTelemetryTracingDockerComposeConnectionDetailsFactoryIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@
2525

2626
/**
2727
* Integration tests for {@link OpenTelemetryTracingDockerComposeConnectionDetailsFactory}
28-
* using {@link TestImage#OPENTELEMETRY}.
28+
* using {@link TestImage#OTEL_COLLECTOR}.
2929
*
3030
* @author Eddú Meléndez
3131
*/
3232
class OpenTelemetryTracingDockerComposeConnectionDetailsFactoryIntegrationTests {
3333

34-
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OPENTELEMETRY)
34+
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OTEL_COLLECTOR)
3535
void runCreatesConnectionDetails(OtlpTracingConnectionDetails connectionDetails) {
3636
assertThat(connectionDetails.getUrl(Transport.HTTP)).startsWith("http://").endsWith("/v1/traces");
3737
assertThat(connectionDetails.getUrl(Transport.GRPC)).startsWith("http://").endsWith("/v1/traces");

module/spring-boot-micrometer-tracing-opentelemetry/src/dockerTest/java/org/springframework/boot/micrometer/tracing/opentelemetry/testcontainers/otlp/OpenTelemetryTracingContainerConnectionDetailsFactoryIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class OpenTelemetryTracingContainerConnectionDetailsFactoryIntegrationTests {
4444

4545
@Container
4646
@ServiceConnection
47-
static final GenericContainer<?> container = TestImage.OPENTELEMETRY.genericContainer()
47+
static final GenericContainer<?> container = TestImage.OTEL_COLLECTOR.genericContainer()
4848
.withExposedPorts(4317, 4318);
4949

5050
@Autowired

module/spring-boot-opentelemetry/src/dockerTest/java/org/springframework/boot/opentelemetry/docker/compose/OtelCollectorOtlpLoggingDockerComposeConnectionDetailsFactoryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*/
3131
class OtelCollectorOtlpLoggingDockerComposeConnectionDetailsFactoryTests {
3232

33-
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OPENTELEMETRY)
33+
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OTEL_COLLECTOR)
3434
void runCreatesConnectionDetails(OtlpLoggingConnectionDetails connectionDetails) {
3535
assertThat(connectionDetails.getUrl(Transport.HTTP)).startsWith("http://").endsWith("/v1/logs");
3636
assertThat(connectionDetails.getUrl(Transport.GRPC)).startsWith("http://").endsWith("/v1/logs");

module/spring-boot-opentelemetry/src/dockerTest/java/org/springframework/boot/opentelemetry/testcontainers/OtelCollectorOltpLoggingContainerConnectionDetailsFactoryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class OtelCollectorOltpLoggingContainerConnectionDetailsFactoryTests {
4444

4545
@Container
4646
@ServiceConnection
47-
static final GenericContainer<?> container = TestImage.OPENTELEMETRY.genericContainer()
47+
static final GenericContainer<?> container = TestImage.OTEL_COLLECTOR.genericContainer()
4848
.withExposedPorts(4317, 4318);
4949

5050
@Autowired

test-support/spring-boot-docker-test-support/src/main/java/org/springframework/boot/testsupport/container/TestImage.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,10 @@ public enum TestImage {
214214
.withStartupTimeout(Duration.ofMinutes(2))),
215215

216216
/**
217-
* A container image suitable for testing Opentelemetry.
217+
* A container image suitable for testing OpenTelemetry using the OpenTelemetry
218+
* collector.
218219
*/
219-
OPENTELEMETRY("otel/opentelemetry-collector-contrib", "0.75.0"),
220+
OTEL_COLLECTOR("otel/opentelemetry-collector-contrib", "0.75.0"),
220221

221222
/**
222223
* A container image suitable for testing Postgres.

0 commit comments

Comments
 (0)