Skip to content

Commit d27aedf

Browse files
committed
Switch Maven plugin to exclude optional dependencies by default
Closes gh-47318
1 parent b3c28f1 commit d27aedf

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/JarIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,14 +181,14 @@ void whenAnEntryIsExcludedItDoesNotAppearInTheRepackagedJar(MavenBuild mavenBuil
181181
}
182182

183183
@TestTemplate
184-
void whenAnEntryIsOptionalByDefaultAppearsInTheRepackagedJar(MavenBuild mavenBuild) {
184+
void whenAnEntryIsOptionalByDefaultDoesNotAppearInTheRepackagedJar(MavenBuild mavenBuild) {
185185
mavenBuild.project("jar-optional-default").goals("install").execute((project) -> {
186186
File repackaged = new File(project, "target/jar-optional-default-0.0.1.BUILD-SNAPSHOT.jar");
187187
assertThat(jar(repackaged)).hasEntryWithNameStartingWith("BOOT-INF/classes/")
188188
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-context")
189189
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-core")
190190
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-jcl")
191-
.hasEntryWithNameStartingWith("BOOT-INF/lib/log4j-api-");
191+
.doesNotHaveEntryWithNameStartingWith("BOOT-INF/lib/log4j-api-");
192192
});
193193
}
194194

build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/AbstractPackagerMojo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ public abstract class AbstractPackagerMojo extends AbstractDependencyFilterMojo
124124
* Include JAR tools.
125125
* @since 3.3.0
126126
*/
127-
@Parameter(defaultValue = "true")
128-
public boolean includeTools = true;
127+
@Parameter(defaultValue = "false")
128+
public boolean includeTools;
129129

130130
/**
131131
* Layer configuration with options to disable layer creation, exclude layer tools

0 commit comments

Comments
 (0)