Skip to content

Commit 8920434

Browse files
committed
Rename OpenTelemetry Logging auto-configuration
It's dealing with OTLP, so the name should reflect that. It now also mirrors the structure from micrometer-tracing-opentelemetry. See gh-47954
1 parent e9172d9 commit 8920434

17 files changed

+199
-224
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,22 @@
1717
package org.springframework.boot.opentelemetry.docker.compose;
1818

1919
import org.springframework.boot.docker.compose.service.connection.test.DockerComposeTest;
20-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingConnectionDetails;
20+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConnectionDetails;
2121
import org.springframework.boot.opentelemetry.autoconfigure.logging.Transport;
2222
import org.springframework.boot.testsupport.container.TestImage;
2323

2424
import static org.assertj.core.api.Assertions.assertThat;
2525

2626
/**
27-
* Integration tests for {@link OpenTelemetryLoggingDockerComposeConnectionDetailsFactory}
28-
* using {@link TestImage#GRAFANA_OTEL_LGTM}.
27+
* Integration tests for {@link OtlpLoggingDockerComposeConnectionDetailsFactory} using
28+
* {@link TestImage#GRAFANA_OTEL_LGTM}.
2929
*
3030
* @author Eddú Meléndez
3131
*/
32-
class GrafanaOpenTelemetryLoggingDockerComposeConnectionDetailsFactoryIntegrationTests {
32+
class GrafanaOtlpLoggingDockerComposeConnectionDetailsFactoryTests {
3333

3434
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.GRAFANA_OTEL_LGTM)
35-
void runCreatesConnectionDetails(OpenTelemetryLoggingConnectionDetails connectionDetails) {
35+
void runCreatesConnectionDetails(OtlpLoggingConnectionDetails connectionDetails) {
3636
assertThat(connectionDetails.getUrl(Transport.HTTP)).startsWith("http://").endsWith("/v1/logs");
3737
assertThat(connectionDetails.getUrl(Transport.GRPC)).startsWith("http://").endsWith("/v1/logs");
3838
}
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,21 @@
1717
package org.springframework.boot.opentelemetry.docker.compose;
1818

1919
import org.springframework.boot.docker.compose.service.connection.test.DockerComposeTest;
20-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingConnectionDetails;
20+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConnectionDetails;
2121
import org.springframework.boot.opentelemetry.autoconfigure.logging.Transport;
2222
import org.springframework.boot.testsupport.container.TestImage;
2323

2424
import static org.assertj.core.api.Assertions.assertThat;
2525

2626
/**
27-
* Integration tests for
28-
* {@link OpenTelemetryLoggingDockerComposeConnectionDetailsFactory}.
27+
* Integration tests for {@link OtlpLoggingDockerComposeConnectionDetailsFactory}.
2928
*
3029
* @author Eddú Meléndez
3130
*/
32-
class OpenTelemetryLoggingDockerComposeConnectionDetailsFactoryIntegrationTests {
31+
class OtelCollectorOtlpLoggingDockerComposeConnectionDetailsFactoryTests {
3332

3433
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.OPENTELEMETRY)
35-
void runCreatesConnectionDetails(OpenTelemetryLoggingConnectionDetails connectionDetails) {
34+
void runCreatesConnectionDetails(OtlpLoggingConnectionDetails connectionDetails) {
3635
assertThat(connectionDetails.getUrl(Transport.HTTP)).startsWith("http://").endsWith("/v1/logs");
3736
assertThat(connectionDetails.getUrl(Transport.GRPC)).startsWith("http://").endsWith("/v1/logs");
3837
}
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
import org.springframework.beans.factory.annotation.Autowired;
2525
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
26-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingConnectionDetails;
27-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingExportAutoConfiguration;
26+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingAutoConfiguration;
27+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConnectionDetails;
2828
import org.springframework.boot.opentelemetry.autoconfigure.logging.Transport;
2929
import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
3030
import org.springframework.boot.testsupport.container.TestImage;
@@ -34,20 +34,20 @@
3434
import static org.assertj.core.api.Assertions.assertThat;
3535

3636
/**
37-
* Tests for {@link GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactory}.
37+
* Tests for {@link GrafanaOtlpLoggingContainerConnectionDetailsFactory}.
3838
*
3939
* @author Eddú Meléndez
4040
*/
4141
@SpringJUnitConfig
4242
@Testcontainers(disabledWithoutDocker = true)
43-
class GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactoryIntegrationTests {
43+
class GrafanaOtlpLoggingContainerConnectionDetailsFactoryTests {
4444

4545
@Container
4646
@ServiceConnection
4747
static final LgtmStackContainer container = TestImage.container(LgtmStackContainer.class);
4848

4949
@Autowired
50-
private OpenTelemetryLoggingConnectionDetails connectionDetails;
50+
private OtlpLoggingConnectionDetails connectionDetails;
5151

5252
@Test
5353
void connectionCanBeMadeToOpenTelemetryContainer() {
@@ -58,7 +58,7 @@ void connectionCanBeMadeToOpenTelemetryContainer() {
5858
}
5959

6060
@Configuration(proxyBeanMethods = false)
61-
@ImportAutoConfiguration(OpenTelemetryLoggingExportAutoConfiguration.class)
61+
@ImportAutoConfiguration(OtlpLoggingAutoConfiguration.class)
6262
static class TestConfiguration {
6363

6464
}
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
import org.springframework.beans.factory.annotation.Autowired;
2525
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
26-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingConnectionDetails;
27-
import org.springframework.boot.opentelemetry.autoconfigure.logging.OpenTelemetryLoggingExportAutoConfiguration;
26+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingAutoConfiguration;
27+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConnectionDetails;
2828
import org.springframework.boot.opentelemetry.autoconfigure.logging.Transport;
2929
import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
3030
import org.springframework.boot.testsupport.container.TestImage;
@@ -34,21 +34,21 @@
3434
import static org.assertj.core.api.Assertions.assertThat;
3535

3636
/**
37-
* Tests for {@link OpenTelemetryLoggingContainerConnectionDetailsFactory}.
37+
* Tests for {@link OtelCollectorOltpLoggingContainerConnectionDetailsFactory}.
3838
*
3939
* @author Eddú Meléndez
4040
*/
4141
@SpringJUnitConfig
4242
@Testcontainers(disabledWithoutDocker = true)
43-
class OpenTelemetryLoggingContainerConnectionDetailsFactoryIntegrationTests {
43+
class OtelCollectorOltpLoggingContainerConnectionDetailsFactoryTests {
4444

4545
@Container
4646
@ServiceConnection
4747
static final GenericContainer<?> container = TestImage.OPENTELEMETRY.genericContainer()
4848
.withExposedPorts(4317, 4318);
4949

5050
@Autowired
51-
private OpenTelemetryLoggingConnectionDetails connectionDetails;
51+
private OtlpLoggingConnectionDetails connectionDetails;
5252

5353
@Test
5454
void connectionCanBeMadeToOpenTelemetryContainer() {
@@ -59,7 +59,7 @@ void connectionCanBeMadeToOpenTelemetryContainer() {
5959
}
6060

6161
@Configuration(proxyBeanMethods = false)
62-
@ImportAutoConfiguration(OpenTelemetryLoggingExportAutoConfiguration.class)
62+
@ImportAutoConfiguration(OtlpLoggingAutoConfiguration.class)
6363
static class TestConfiguration {
6464

6565
}

module/spring-boot-opentelemetry/src/main/java/org/springframework/boot/opentelemetry/autoconfigure/logging/OpenTelemetryLoggingConnectionDetailsConfiguration.java

Lines changed: 0 additions & 65 deletions
This file was deleted.

module/spring-boot-opentelemetry/src/main/java/org/springframework/boot/opentelemetry/autoconfigure/logging/OpenTelemetryLoggingTransportConfiguration.java

Lines changed: 0 additions & 75 deletions
This file was deleted.
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2525
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2626
import org.springframework.boot.context.properties.EnableConfigurationProperties;
27+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConfigurations.ConnectionDetails;
28+
import org.springframework.boot.opentelemetry.autoconfigure.logging.OtlpLoggingConfigurations.Exporters;
2729
import org.springframework.context.annotation.Import;
2830

2931
/**
@@ -35,8 +37,8 @@
3537
@AutoConfiguration
3638
@ConditionalOnClass({ ConditionalOnEnabledLoggingExport.class, OpenTelemetry.class, SdkLoggerProvider.class })
3739
@ConditionalOnEnabledLoggingExport("opentelemetry")
38-
@EnableConfigurationProperties(OpenTelemetryLoggingExportProperties.class)
39-
@Import({ OpenTelemetryLoggingConnectionDetailsConfiguration.class, OpenTelemetryLoggingTransportConfiguration.class })
40-
public final class OpenTelemetryLoggingExportAutoConfiguration {
40+
@EnableConfigurationProperties(OtlpLoggingProperties.class)
41+
@Import({ ConnectionDetails.class, Exporters.class })
42+
public final class OtlpLoggingAutoConfiguration {
4143

4244
}

0 commit comments

Comments
 (0)